Introduce retention lease persistence #37375
Merged
+386
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the persistence of retention leases by persisting them in index commits and recovering them when recovering a shard from store.
jasontedor
added
>enhancement
v7.0.0
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed |
24 tasks
|
@elasticmachine run gradle build tests 2 |
|
Thanks @dnhatn, I have responded to your feedback. |
…rsistence * elastic/master: Fix PrimaryAllocationIT Race Condition (elastic#37355) SQL: Make `FULL` non-reserved keyword in the grammar (elastic#37377) SQL: [Tests] Fix and enable internalClusterTests (elastic#37300) ML: Fix testMigrateConfigs (elastic#37373) Fix RollupDocumentation test to wait for job to stop
|
@elasticmachine run gradle build tests 1 |
jasontedor
added a commit
that referenced
this pull request
Jan 12, 2019
This commit introduces the persistence of retention leases by persisting them in index commits and recovering them when recovering a shard from store.
bleskes
reviewed
Jan 14, 2019
| Objects.requireNonNull(retentionLease); | ||
| return String.format( | ||
| Locale.ROOT, | ||
| "id:%s;retaining_seq_no:%d;timestamp:%d;source:%s", |
There was a problem hiding this comment.
I wonder if we should use JSON, with the upside of being more extensible and will allow us to use our parsing infra (and the validation features it has). WDYT?
There was a problem hiding this comment.
I am not particularly concerned about this needing to be extensible. I can be convinced that JSON is worth it but I am doubting.
dnhatn
added a commit
that referenced
this pull request
Jan 31, 2019
dnhatn
added a commit
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the persistence of retention leases by persisting them in index commits and recovering them when recovering a shard from store.
Relates #37165