Performance fix. Reduce deprecation calls for the same bulk request #37415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
v7.0.0
>regression
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
colings86
reviewed
Jan 14, 2019
| if (typesDeprecationLogged == false) { | ||
| deprecationLogger.deprecatedAndMaybeLog("bulk_with_types", RestBulkAction.TYPES_DEPRECATION_MESSAGE); | ||
| typesDeprecationLogged = true; | ||
| } |
There was a problem hiding this comment.
Could we add a test that checks that only 1 deprecation warning is returned when the bulk request would previously generate multiple?
There was a problem hiding this comment.
I think they're thinned out already in DeprecationLogger/ThreadContext?
It dedups values added to the response header
This PR just adds a more performant way of thinning them out.
There was a problem hiding this comment.
ok, I see. In which case I think we should test to make sure this actually fixes the performance issue before we merge it as I didn't see that we already deduplicate the warning headers. Maybe we can run one of the rally tracks against this PR?
There was a problem hiding this comment.
This seems to fix the drop.
With the earlier commit (4344305) geopoint default had the following indexing throughput:
| All | Min Throughput | index-append | 216469 | docs/s |
| All | Median Throughput | index-append | 220417 | docs/s |
| All | Max Throughput | index-append | 222044 | docs/s |
whereas with this commit:
| All | Min Throughput | index-append | 302604 | docs/s |
| All | Median Throughput | index-append | 312456 | docs/s |
| All | Max Throughput | index-append | 315466 | docs/s |
which seems to be roughly the same performance we had before the pending PR/commit i.e. using 04dcb13:
| All | Min Throughput | index-append | 312749 | docs/s |
| All | Median Throughput | index-append | 316424 | docs/s |
| All | Max Throughput | index-append | 318845 | docs/s |
For the record the Rally command in a 1node env with separate load generator:
rally --skip-update --configuration-name=adhoc --target-host="192.168.14.13:39200" --track="geopoint" --car="defaults" --challenge="append-no-conflicts" --user-tag="env:bare,name:geopoint-append-defaults-1node" --pipeline="from-sources-complete" --revision="4344305" --include-tasks="delete-index,create-index,check-cluster-health,index-append,refresh-after-index,force-merge,refresh-after-force-merge" --user-tag="geopoint:regression"
vs
rally --skip-update --configuration-name=adhoc --target-host="192.168.14.13:39200" --track="geopoint" --car="defaults" --challenge="append-no-conflicts" --user-tag="env:bare,name:geopoint-append-defaults-1node" --pipeline="from-sources-skip-build" --revision="72f71a0e" --include-tasks="delete-index,create-index,check-cluster-health,index-append,refresh-after-index,force-merge,refresh-after-force-merge" --user-tag="geopoint:fix"
jpountz
approved these changes
Jan 14, 2019
markharwood
force-pushed
the
fix/37411
branch
from
8dd2a37 to
72f71a0
Compare
markharwood
force-pushed
the
fix/37411
branch
from
72f71a0 to
1544ed7
Compare
dliappis
approved these changes
Jan 14, 2019
| if (typesDeprecationLogged == false) { | ||
| deprecationLogger.deprecatedAndMaybeLog("bulk_with_types", RestBulkAction.TYPES_DEPRECATION_MESSAGE); | ||
| typesDeprecationLogged = true; | ||
| } |
There was a problem hiding this comment.
This seems to fix the drop.
With the earlier commit (4344305) geopoint default had the following indexing throughput:
| All | Min Throughput | index-append | 216469 | docs/s |
| All | Median Throughput | index-append | 220417 | docs/s |
| All | Max Throughput | index-append | 222044 | docs/s |
whereas with this commit:
| All | Min Throughput | index-append | 302604 | docs/s |
| All | Median Throughput | index-append | 312456 | docs/s |
| All | Max Throughput | index-append | 315466 | docs/s |
which seems to be roughly the same performance we had before the pending PR/commit i.e. using 04dcb13:
| All | Min Throughput | index-append | 312749 | docs/s |
| All | Median Throughput | index-append | 316424 | docs/s |
| All | Max Throughput | index-append | 318845 | docs/s |
For the record the Rally command in a 1node env with separate load generator:
rally --skip-update --configuration-name=adhoc --target-host="192.168.14.13:39200" --track="geopoint" --car="defaults" --challenge="append-no-conflicts" --user-tag="env:bare,name:geopoint-append-defaults-1node" --pipeline="from-sources-complete" --revision="4344305" --include-tasks="delete-index,create-index,check-cluster-health,index-append,refresh-after-index,force-merge,refresh-after-force-merge" --user-tag="geopoint:regression"
vs
rally --skip-update --configuration-name=adhoc --target-host="192.168.14.13:39200" --track="geopoint" --car="defaults" --challenge="append-no-conflicts" --user-tag="env:bare,name:geopoint-append-defaults-1node" --pipeline="from-sources-skip-build" --revision="72f71a0e" --include-tasks="delete-index,create-index,check-cluster-health,index-append,refresh-after-index,force-merge,refresh-after-force-merge" --user-tag="geopoint:fix"
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 15, 2019
* master: (28 commits) Introduce retention lease serialization (elastic#37447) Update Delete Watch to allow unknown fields (elastic#37435) Make finalize step of recovery source non-blocking (elastic#37388) Update the default for include_type_name to false. (elastic#37285) Security: remove SSL settings fallback (elastic#36846) Adding mapping for hostname field (elastic#37288) Relax assertSameDocIdsOnShards assertion Reduce recovery time with compress or secure transport (elastic#36981) Implement ccr file restore (elastic#37130) Fix Eclipse specific compilation issue (elastic#37419) Performance fix. Reduce deprecation calls for the same bulk request (elastic#37415) [ML] Use String rep of Version in map for serialisation (elastic#37416) Cleanup Deadcode in Rest Tests (elastic#37418) Mute IndexShardRetentionLeaseTests.testCommit elastic#37420 unmuted test Remove unused index store in directory service Improve CloseWhileRelocatingShardsIT (elastic#37348) Fix ClusterBlock serialization and Close Index API logic after backport to 6.x (elastic#37360) Update the scroll example in the docs (elastic#37394) Update analysis.asciidoc (elastic#37404) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only log one types deprecation warning per bulk request.
Related to #37411