Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line length for aliases and remove suppression #37455

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fix line length for aliases and remove suppression #37455

merged 1 commit into from
Jan 16, 2019

Conversation

dliappis
Copy link
Contributor

Relates #34884

@dliappis dliappis added the :Core/Infra/Core Core issues without another label label Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dliappis dliappis requested a review from pgomulka January 15, 2019 08:04
@dakrone dakrone mentioned this pull request Jan 15, 2019
Closed
33 tasks
@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 1

@dliappis
Copy link
Contributor Author

jenkins run the default distro tests

dakrone
dakrone approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis force-pushed the line-length-aliases branch from da73df3 to e98ddfb Compare January 15, 2019 18:39
@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 2

1 similar comment
@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 2

@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 1

@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 2

@dliappis dliappis merged commit 347cbaf into elastic:master Jan 16, 2019
dliappis added a commit that referenced this pull request Jan 16, 2019
@dliappis
Fix line length for aliases and remove suppression (#37455)
28e8561 
Relates #34884
@dliappis
Copy link
Contributor Author

Cherry picked 6.x -> 28e8561

@dliappis dliappis deleted the line-length-aliases branch January 16, 2019 13:21
cshtdd added a commit to cshtdd/elasticsearch that referenced this pull request Jan 16, 2019
@cshtdd
Merge branch 'master' into issue_37107
d06ba4d 
* master:
  Deprecate _type from LeafDocLookup (elastic#37491)
  Allow system privilege to execute proxied actions (elastic#37508)
  Update Put Watch to allow unknown fields (elastic#37494)
  AwaitsFix testAddNewReplicas
  SQL: Add protocol tests and remove jdbc_type from drivers response (elastic#37516)
  SQL: [Docs] Add an ES-SQL column for data types (elastic#37529)
  IndexMetaData#mappingOrDefault doesn't need to take a type argument. (elastic#37480)
  Simplify + Cleanup Dead Code in Settings (elastic#37341)
  Reject all requests that have an unconsumed body (elastic#37504)
  [Ml] Prevent config snapshot failure blocking migration (elastic#37493)
  Fix line length for aliases and remove suppression (elastic#37455)
  Add SSL Configuration Library (elastic#37287)
  SQL: Remove slightly used meta commands (elastic#37506)
  Simplify Snapshot Create Request Handling (elastic#37464)
  Remove the use of AbstracLifecycleComponent constructor elastic#37488 (elastic#37488)
  [ML] log minimum diskspace setting if forecast fails due to insufficient d… (elastic#37486)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

@pgomulka pgomulka Awaiting requested review from pgomulka

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >non-issue v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dliappis @elasticmachine @dakrone @colings86