Deprecate HLRC EmptyResponse used by security #37540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EmptyResponse is essentially the same as returning a boolean, which is done in other places. This commit deprecates all the existing EmptyResponse methods and creates new boolean methods that have method params reordered so they can exist with the deprecated methods. A followup PR in master will remove the existing deprecated methods, fix the parameter ordering and deprecate the incorrectly ordered parameter methods. Relates elastic#36938
hub-cap
added
>enhancement
v7.0.0
:Core/Features/Java High Level REST Client
:Security/Security
|
Pinging @elastic/es-core-features |
|
Pinging @elastic/es-security |
|
I went ahead and added the |
|
@elasticmachine run gradle build tests 1 |
tvernum
reviewed
Jan 16, 2019
| * | ||
| * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized | ||
| * @param request the request with the user to enable | ||
| * @return the response from the enable user call |
There was a problem hiding this comment.
This doesn't make much sense to me since it returns a boolean.
Suggested change
| * @return the response from the enable user call | |
| * @return {@code true} if the request succeeded (the user is enabled) |
| * | ||
| * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized | ||
| * @param request the request with the user to disable | ||
| * @return the response from the enable user call |
There was a problem hiding this comment.
Suggested change
| * @return the response from the enable user call | |
| * @return {@code true} if the request succeeded (the user is disabled) |
| * | ||
| * @param options the request options (e.g. headers), use {@link RequestOptions#DEFAULT} if nothing needs to be customized | ||
| * @param request the request with the user's new password | ||
| * @return the response from the change user password call |
There was a problem hiding this comment.
Suggested change
| * @return the response from the change user password call | |
| * @return {@code true} if the request succeeded (the new password was set) |
| @@ -26,7 +26,9 @@ | |||
|
|
|||
| /** | |||
| * Response for a request which simply returns an empty object. | |||
| @deprecated Use a boolean to instead of this class | |||
There was a problem hiding this comment.
Suggested change
| @deprecated Use a boolean to instead of this class | |
| @deprecated Use a boolean instead of this class |
😿 |
|
ty for the review. Ive fixed the tests and added the wording differences you mentioned above. <3 |
|
@elasticmachine run gradle build tests 1 |
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Jan 17, 2019
This commit deprecates the few methods that had their parameters reordered to facilitate the move from EmptyResponse to boolean. This commit also readds the boolean based methods with the proper signatures. Relates elastic#37540 Relates elastic#36938
25 tasks
hub-cap
added a commit
that referenced
this pull request
Jan 24, 2019
The EmptyResponse is essentially the same as returning a boolean, which is done in other places. This commit deprecates all the existing EmptyResponse methods and creates new boolean methods that have method params reordered so they can exist with the deprecated methods. A followup PR in master will remove the existing deprecated methods, fix the parameter ordering and deprecate the incorrectly ordered parameter methods. Relates #36938
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 24, 2019
* elastic/master: Optimize warning header de-duplication (elastic#37725) Bubble exceptions up in ClusterApplierService (elastic#37729) SQL: Improve handling of invalid args for PERCENTILE/PERCENTILE_RANK (elastic#37803) Remove unused ThreadBarrier class (elastic#37666) Add built-in user and role for code plugin (elastic#37030) Consolidate testclusters tests into a single project (elastic#37362) Fix docs for MappingUpdatedAction SQL: Introduce SQL DATE data type (elastic#37693) disabling bwc test while backporting elastic#37639 Mute ClusterDisruptionIT testAckedIndexing Set acking timeout to 0 on dynamic mapping update (elastic#31140) Remove index audit output type (elastic#37707) Mute FollowerFailOverIT testReadRequestsReturnsLatestMappingVersion [ML] Increase close job timeout and lower the max number (elastic#37770) Remove Custom Listeners from SnapshotsService (elastic#37629) Use m_m_nodes from Zen1 master for Zen2 bootstrap (elastic#37701) Fix index filtering in follow info api. (elastic#37752) Use project dependency instead of substitutions for distributions (elastic#37730) Update authenticate to allow unknown fields (elastic#37713) Deprecate HLRC EmptyResponse used by security (elastic#37540)
hub-cap
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Jan 25, 2019
This commit deprecates the few methods that had their parameters reordered to facilitate the move from EmptyResponse to boolean. This commit also readds the boolean based methods with the proper signatures. Relates elastic#37540 Relates elastic#36938
hub-cap
added a commit
that referenced
this pull request
Feb 4, 2019
danielmitterdorfer
removed
the
:Security/Security
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EmptyResponse is essentially the same as returning a boolean, which
is done in other places. This commit deprecates all the existing
EmptyResponse methods and creates new boolean methods that have method
params reordered so they can exist with the deprecated methods. A
followup PR in master will remove the existing deprecated methods, fix
the parameter ordering and deprecate the incorrectly ordered parameter
methods.
Relates #36938