-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail start on obsolete indices documentation #37786
Fail start on obsolete indices documentation #37786
Conversation
Added breaking changes documentation for node start up obsolete indices detection. Issue elastic#27073
Pinging @elastic/es-distributed |
Minor formatting corrections Issue elastic#27073
@@ -58,3 +59,4 @@ include::migrate_7_0/scripting.asciidoc[] | |||
include::migrate_7_0/snapshotstats.asciidoc[] | |||
include::migrate_7_0/restclient.asciidoc[] | |||
include::migrate_7_0/low_level_restclient.asciidoc[] | |||
include::migrate_7_0/node_start.asciidoc[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the documentation for the different node modes is under the node
module (see https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-node.html), perhaps name this node.asciidoc
and the label above <<breaking_70_node_changes>>
=== Node start up | ||
|
||
[float] | ||
==== Node start up detects and fails on obsolete indices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the "obsolete" word here. How about: "Nodes with left-behind data or metadata refuse to start"
|
||
[float] | ||
==== Node start up detects and fails on obsolete indices | ||
To avoid importing obsolete dangling indices, node start up will fail in following two situations: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alternative formulation:
Repurposing an existing node by changing node.master
or node.data
to false
can leave lingering on-disk metadata and data around, which will not be accessible by the node's new role. Beside storing non-accessible data, this can lead to situations where dangling indices are imported even though the node might not be able to host any shards, leading to a red cluster health. To avoid this,
- nodes with on-disk shard data and
node.data
set tofalse
will refuse to start - nodes with on-disk index/shard data and both
node.master
andnode.data
set tofalse
will refuse to start
Beware that such role changes done prior to the 7.0 upgrade could prevent node startup in 7.0.
Improved documentation on when nodes will refuse to start up. Issue elastic#27073
@ywelsch : Thanks for the improved documentation suggestions, I incorporated them verbatim (except for a space), please have another go at this at your convenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ersion * elastic/master: Do not set up NodeAndClusterIdStateListener in test (elastic#38110) ML: better handle task state race condition (elastic#38040) Soft-deletes policy should always fetch latest leases (elastic#37940) Handle scheduler exceptions (elastic#38014) Minor logging improvements (elastic#38084) Fix Painless void return bug (elastic#38046) Update PutFollowAction serialization post-backport (elastic#37989) fix a few versionAdded values in ElasticsearchExceptions (elastic#37877) Reenable BWC tests after backport of elastic#37899 (elastic#38093) Mute failing test Mute failing test Fail start on obsolete indices documentation (elastic#37786) SQL: Implement FIRST/LAST aggregate functions (elastic#37936) Un-mute NoMasterNodeIT.testNoMasterActionsWriteMasterBlock remove unused parser fields in RemoteResponseParsers
Added breaking changes documentation for node start up obsolete indices
detection.
Issue #27073
We could consider adding information on how to recover, but I fear that someone might carry them out wrongly leading to an even worse situation? WDYT