Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for mapping ready in testReadRequestsReturnLatestMappingVersion #37886

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 25, 2019

If the index request is executed before the put-mapping update is applied on
the IndexShard, the index request will perform a dynamic mapping update.
This mapping update will be timeout (i.e, ProcessClusterEventTimeoutException)
because the latch is still closed. This leads to the failure of the index
request and the test. This commit makes sure the mapping is ready
before we execute the index request.

Relates #37633
Closes #37807

If the index request is executed before the mapping update is applied on
the IndexShard, the index request will perform a dynamic mapping update.
This mapping update will be timeout (i.e, ProcessClusterEventTimeoutException)
because the latch is not open. This leads to the failure of the index
request and the test. This commit makes sure the mapping is ready
before we execute the index request.

Closes elastic#37807
@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests v7.0.0 :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.7.0 v6.6.1 labels Jan 25, 2019
@dnhatn dnhatn requested review from martijnvg and ywelsch January 25, 2019 20:41
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 28, 2019

Thanks @martijnvg.

@dnhatn dnhatn merged commit 557fcf9 into elastic:master Jan 28, 2019
@dnhatn dnhatn deleted the block-mapping-test branch January 28, 2019 20:26
dnhatn added a commit that referenced this pull request Jan 31, 2019
If the index request is executed before the mapping update is applied on
the IndexShard, the index request will perform a dynamic mapping update.
This mapping update will be timeout (i.e, ProcessClusterEventTimeoutException)
because the latch is not open. This leads to the failure of the index
request and the test. This commit makes sure the mapping is ready
before we execute the index request.

Closes #37807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] FollowerFailOverIT testReadRequestsReturnsLatestMappingVersion failed
4 participants