Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented default values for index follow request parameters. #37917

Merged

Conversation

martijnvg
Copy link
Member

No description provided.

@martijnvg martijnvg added >docs General docs changes v7.0.0 :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features v6.7.0 labels Jan 28, 2019
@martijnvg martijnvg requested a review from jasontedor January 28, 2019 11:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martijnvg martijnvg merged commit 4da7a44 into elastic:master Jan 30, 2019
@jpountz
Copy link
Contributor

jpountz commented Jan 30, 2019

@martijnvg FYI this change triggered a failure of the intake build that reproduces locally so I reverted this change for now: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+intake/1642/consoleFull.

jpountz added a commit that referenced this pull request Jan 30, 2019
martijnvg added a commit that referenced this pull request Jan 30, 2019
martijnvg added a commit that referenced this pull request Jan 30, 2019
(a restore needs to be complete, which happens in the background and
by default the ccr put follow api doesn't wait for this)

(this was a recent change and the pr that added this docs test,
did not include this change)

Relates to #37917
@martijnvg
Copy link
Member Author

@jpountz Thanks for muting. I've fixed the issue with the above two commits. Basically #37988 was merged in master and this pr wasn't updated.

I will wait with backporting when #37988 has been merged. The avoid the risk of more build failures if this get backported and that pr not being updated.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 30, 2019
* master: (29 commits)
  Fix limit on retaining sequence number (elastic#37992)
  Docs test fix, wait for shards active.
  Revert "Revert "Documented default values for index follow request parameters. (elastic#37917)""
  Revert "Documented default values for index follow request parameters. (elastic#37917)"
  Ensure date parsing BWC compatibility (elastic#37929)
  SQL: Skip the nested and object field types in case of an ODBC request (elastic#37948)
  Use mappings to format doc-value fields by default. (elastic#30831)
  Give precedence to index creation when mixing typed templates with typeless index creation and vice-versa. (elastic#37871)
  Add classifier to tar.gz in docker compose (elastic#38011)
  Documented default values for index follow request parameters. (elastic#37917)
  Fix fetch source option in expand search phase (elastic#37908)
  Restore a noop _all metadata field for 6x indices (elastic#37808)
  Added ccr to xpack usage infrastructure (elastic#37256)
  Fix exit code for Security CLI tools  (elastic#37956)
  Streamline S3 Repository- and Client-Settings (elastic#37393)
  Add version 6.6.1 (elastic#37975)
  Ensure task metadata not null in follow test (elastic#37993)
  Docs fix - missing callout
  Types removal - deprecate include_type_name with index templates (elastic#37484)
  Handle completion suggestion without contexts
  ...
martijnvg added a commit to martijnvg/elasticsearch that referenced this pull request Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >docs General docs changes v6.7.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants