Run Node deprecation checks locally #38065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At times, we need to check for usage of deprecated settings in settings which should not be returned by the NodeInfo API. This commit changes the deprecation info API to run all node checks locally so that these settings can be checked without exposing them via any externally accessible API.
|
Pinging @elastic/es-core-features |
dakrone
requested changes
Jan 31, 2019
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(getClusterName(), getNodes()); |
There was a problem hiding this comment.
This needs to hash the failures also
|
|
||
| import org.elasticsearch.test.AbstractStreamableTestCase; | ||
|
|
||
| public class NodesDeprecationCheckRequestTests |
There was a problem hiding this comment.
Can you add a mutateInstance method to this so the hashcode is also tested?
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| public class NodesDeprecationCheckResponseTests |
There was a problem hiding this comment.
Same here about a mutateInstance override
| List<String> failedNodeIds = response.failures().stream() | ||
| .map(failure -> failure.nodeId() + ": " + failure.getMessage()) | ||
| .collect(Collectors.toList()); | ||
| logger.error("Nodes failed to run deprecation checks: {}", failedNodeIds); |
There was a problem hiding this comment.
super minor nit, but generally we don't capitalize our log messages
|
I've completed the items indicated above so this is no longer a WIP, as well as addressing all of @dakrone's feedback above. |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Feb 2, 2019
At times, we need to check for usage of deprecated settings in settings which should not be returned by the NodeInfo API. This commit changes the deprecation info API to run all node checks locally so that these settings can be checked without exposing them via any externally accessible API.
gwbrown
added a commit
that referenced
this pull request
Feb 4, 2019
At times, we need to check for usage of deprecated settings in settings which should not be returned by the NodeInfo API. This commit changes the deprecation info API to run all node checks locally so that these settings can be checked without exposing them via any externally accessible API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At times, we need to check for usage of deprecated settings in settings
which should not be returned by the NodeInfo API. This commit changes
the deprecation info API to run all node checks locally so that these
settings can be checked without exposing them via any externally
accessible API.
Resolves #37845
This needs to go into both 6.x and master, but as this involves changes to many of the node deprecation checks that only exist in 6.x, my plan is to merge this initially to 6.x and forward-port to master.
This is marked as WIP because I still need to:
Settings,PluginsAndModules, etc. directly rather than a list of NodeInfo objectsnulldetail message better (currently shows up as"null (nodes impacted: [node-1, node-2])")