Use current term in initial leases in engine test #38285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use the current primary term instead of 1L for the initial retention leases; otherwise, the primary term of the committed retention-leases won't match the current primary term if the etention-leases never gets updated.
dnhatn
added
>test
|
Pinging @elastic/es-distributed |
|
@dnhatn can we mute the test while this PR is not merged? I saw this happening again on 6.7 today: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.7+corretto-periodic/ES_BUILD_JAVA=java11,label=amazon/4/console |
|
Other occurances: Since its also failing on master I assume that 7.x and 7.0 are also affected. Will open a mute-PR against master, please let me know if you are okay muting this. |
|
@cbuescher @jasontedor thanks. |
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We need to use the current primary term instead of 1L for the initial retention leases; otherwise, the primary term of the committed retention leases won't match the current primary term if the retention leases never gets updated.
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We need to use the current primary term instead of 1L for the initial retention leases; otherwise, the primary term of the committed retention leases won't match the current primary term if the retention leases never gets updated.
dnhatn
added a commit
that referenced
this pull request
Feb 12, 2019
We need to use the current primary term instead of 1L for the initial retention leases; otherwise, the primary term of the committed retention leases won't match the current primary term if the retention leases never gets updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the current primary term instead of 1L for the initial
retention leases; otherwise, the primary term of the committed
retention-leases won't match the current primary term if the
retention-leases never gets updated.
CI: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=openjdk12,ES_RUNTIME_JAVA=zulu8,nodes=immutable&&linux&&docker/220/console