Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add warning about bypassing ML PUT APIs #38509

Merged
merged 2 commits into from
Feb 8, 2019
Merged

[DOCS] Add warning about bypassing ML PUT APIs #38509

merged 2 commits into from
Feb 8, 2019

Conversation

droberts195
Copy link
Contributor

Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index. Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

@droberts195
[DOCS] Add warning about bypassing ML PUT APIs
70ad20d 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.
@droberts195 droberts195 added >docs General docs changes v7.0.0 :ml Machine learning v6.7.0 v8.0.0 labels Feb 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

hendrikmuhs
hendrikmuhs approved these changes Feb 6, 2019
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 requested a review from lcawl February 6, 2019 13:09
@jasontedor jasontedor removed the v7.0.0 label Feb 6, 2019
@jasontedor jasontedor added v7.0.0 and removed v7.0.0 labels Feb 6, 2019
@lcawl @droberts195
Apply suggestions from code review
dfa1004 
Co-Authored-By: droberts195 <dave.roberts@elastic.co>
@droberts195
Copy link
Contributor Author

Thanks for all the edits @lcawl.

FYI I copied the text from https://github.com/elastic/elasticsearch/blame/master/x-pack/docs/en/rest-api/watcher/put-watch.asciidoc#L24, so I'm not sure if you want to change that to match the new wording in this PR?

lcawl
lcawl approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl mentioned this pull request Feb 7, 2019
Merged
@droberts195 droberts195 merged commit 4184524 into elastic:master Feb 8, 2019
@droberts195 droberts195 deleted the add_config_index_warning branch February 8, 2019 10:44
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs
c96e2e0 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of elastic#38509
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs
62539ef 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of elastic#38509
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs
bb8dcaf 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of elastic#38509
This was referenced Feb 8, 2019
Merged
Merged
Merged
Merged
droberts195 added a commit that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs (#38605)
02f57b1 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of #38509
droberts195 added a commit that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs (#38607)
869843b 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of #38509
droberts195 added a commit that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs (#38608)
0b0af8c 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of #38509
droberts195 added a commit that referenced this pull request Feb 8, 2019
@droberts195
[DOCS] Add warning about bypassing ML PUT APIs (#38606)
9d7b170 
Now that ML configurations are stored in the .ml-config
index rather than in cluster state there is a possibility
that some users may try to add configurations directly to
the index.  Allowing this creates a variety of problems
including possible data exflitration attacks (depending on
how security is set up), so this commit adds warnings
against allowing writes to the .ml-config index other than
via the ML APIs.

Backport of #38509
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 8, 2019
@jasontedor
Merge branch 'master' into docker-from-artifacts
4730a64 
* master:
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  Mute failing WatchStatusIntegrationTests (elastic#38621)
  Mute failing  ApiKeyIntegTests (elastic#38614)
  [DOCS] Add warning about bypassing ML PUT APIs (elastic#38509)
  Add 7.1 and 8.0 version constants to master (elastic#38514)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 8, 2019
@jasontedor
Merge branch 'master' into llrc-java-7
b6612e9 
* master:
  Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636)
  add geotile_grid ref to asciidoc (elastic#38632)
  Enable Dockerfile from artifacts.elastic.co (elastic#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634)
  Account for a possible rolled over file while reading the audit log file (elastic#34909)
  Mute failure in InternalEngineTests (elastic#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518)
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  Mute failing WatchStatusIntegrationTests (elastic#38621)
  Mute failing  ApiKeyIntegTests (elastic#38614)
  [DOCS] Add warning about bypassing ML PUT APIs (elastic#38509)
  Add 7.1 and 8.0 version constants to master (elastic#38514)
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 11, 2019
@jasontedor
Merge branch 'master' into retention-lease-ccr
affec57 
* master: (27 commits)
  Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636)
  add geotile_grid ref to asciidoc (elastic#38632)
  Enable Dockerfile from artifacts.elastic.co (elastic#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634)
  Account for a possible rolled over file while reading the audit log file (elastic#34909)
  Mute failure in InternalEngineTests (elastic#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518)
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  Mute failing WatchStatusIntegrationTests (elastic#38621)
  Mute failing  ApiKeyIntegTests (elastic#38614)
  [DOCS] Add warning about bypassing ML PUT APIs (elastic#38509)
  Add 7.1 and 8.0 version constants to master (elastic#38514)
  ML: update set_upgrade_mode, add logging (elastic#38372)
  bad formatted JSON object (elastic#38515) (elastic#38525)
  Fix HistoryIntegrationTests timestamp comparsion (elastic#38505)
  SQL: Fix issue with IN not resolving to underlying keyword field (elastic#38440)
  Fix the clock resolution to millis in ScheduledEventTests (elastic#38506)
  Enable BWC after backport recovering leases (elastic#38485)
  Collapse retention lease integration tests (elastic#38483)
  TransportVerifyShardBeforeCloseAction should force a flush (elastic#38401)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :ml Machine learning v6.6.0 v6.7.0 v7.0.0-beta1 v7.2.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@droberts195 @elasticmachine @hendrikmuhs @lcawl @jakelandis @danielmitterdorfer @jasontedor @jimczi