Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add seqNo related assertions to TokenService #38563

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Add seqNo related assertions to TokenService #38563

merged 1 commit into from
Feb 11, 2019

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Feb 7, 2019

These were suggested by @albertzaharovits in #38311 (review)

@bleskes bleskes added >non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v6.7.0 labels Feb 7, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

albertzaharovits
albertzaharovits approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@albertzaharovits albertzaharovits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the follow up

@bleskes bleskes merged commit cb1b8a1 into elastic:6.7 Feb 11, 2019
@bleskes bleskes deleted the cas_assertion_token_service branch February 11, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees
No one assigned
Labels
>non-issue :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bleskes @elasticmachine @albertzaharovits @danielmitterdorfer