Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 9, 2019

With this change, we can automatically detect an implementation that acquires an index commit but fails to release.

@dnhatn dnhatn added >enhancement :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.2.0 labels Feb 9, 2019
@dnhatn dnhatn requested a review from ywelsch February 9, 2019 14:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch
Copy link
Contributor

ywelsch commented Feb 11, 2019

Let's backport this to 6.x as well, as it can help uncover bugs

@ywelsch ywelsch added >test Issues or PRs that are addressing/adding tests and removed >enhancement labels Feb 11, 2019
@dnhatn
Copy link
Member Author

dnhatn commented Feb 11, 2019

Thanks @ywelsch

@dnhatn dnhatn merged commit 8bc87d1 into elastic:master Feb 11, 2019
@dnhatn dnhatn deleted the fail-pending-snapshots branch February 11, 2019 15:21
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 11, 2019
With this change, we can automatically detect an implementation 
that acquires an index commit but fails to release.
dnhatn added a commit that referenced this pull request Feb 12, 2019
With this change, we can automatically detect an implementation 
that acquires an index commit but fails to release.
dnhatn added a commit that referenced this pull request Feb 12, 2019
With this change, we can automatically detect an implementation 
that acquires an index commit but fails to release.
dnhatn added a commit that referenced this pull request Feb 12, 2019
With this change, we can automatically detect an implementation 
that acquires an index commit but fails to release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v6.7.0 v7.0.0-beta1 v7.2.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants