Correct rebuilding of Persian analyzer #38724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make substitution of \u200C with a space explicit Closes elastic#38188
cbuescher
requested changes
Feb 11, 2019
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Actually, looking at #38188 (comment) which was just added it seems other analyzers in this documentation page might have similar issues. Can you check if that failure is related and maybe fix it in the same PR?
cbuescher
approved these changes
Feb 11, 2019
Member
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
Sorry for the noise, just doule-checked and its the same error on 7.x. I missread the line-numbers and thought they are different.
Contributor
Author
|
@cbuescher thanks a lot |
mayya-sharipova
added
>docs
mayya-sharipova
added a commit
that referenced
this pull request
Feb 11, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes #38188
mayya-sharipova
added a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Feb 11, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes elastic#38188
mayya-sharipova
added a commit
that referenced
this pull request
Feb 11, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes #38188
benwtrent
pushed a commit
to benwtrent/elasticsearch
that referenced
this pull request
Feb 21, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes elastic#38188
benwtrent
added a commit
that referenced
this pull request
Feb 21, 2019
Make substitution of \u200C with a space explicit The problem with this symbol `\u200C` in a test string, that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not. Correcting this line `"mappings": [ "\\u200C=> "] <1>` to `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem. This change explicitly says to substitute ZWNJ with a space. Closes #38188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make substitution of \u200C with a space explicit
The problem with this symbol
\u200Cin a test string, that SHOULD be substituted with space in the rebuilt Persian analyzer, but it is not.Correcting this line
"mappings": [ "\\u200C=> "] <1>to"mappings": [ "\\u200C=>\\u0020"] <1>inlang-analyzer solves the problem.
This change explicitly says to substitute ZWNJ with a space.
Closes #38188