Build: Fix issue with test status logging #38799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
|
Pinging @elastic/es-core-infra |
rjernst
reviewed
Feb 12, 2019
| return className.substring(className.lastIndexOf('.') + 1) | ||
| private static String simpleName(Description description) { | ||
| if (description == null) { | ||
| return "<unknown>" |
There was a problem hiding this comment.
Maybe this should indicate unknown class, and in the test name we should add unknown test?
There was a problem hiding this comment.
My thinking is: if the description is null then we cannot know either.
I believe, there is no case that the class is unknown but the method isn't or the opposite.
There was a problem hiding this comment.
I mean that we should be more explicit with unknown class vs unknown test.
|
@rjernst thx, fixup pushed. |
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
This was referenced Feb 15, 2019
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
matriv
added a commit
that referenced
this pull request
Feb 15, 2019
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 15, 2019
Handle the case of `Description` being null which is a valid case as described in the `HeartBeatEvent`'s javadoc, which previously resulted in exceptions that "pollute" the build output. Follows: elastic#28563
matriv
added a commit
that referenced
this pull request
Feb 15, 2019
matriv
added a commit
that referenced
this pull request
Feb 15, 2019
matriv
added a commit
that referenced
this pull request
Feb 15, 2019
matriv
added a commit
that referenced
this pull request
Feb 15, 2019
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 15, 2019
* elastic/master: Avoid double term construction in DfsPhase (elastic#38716) Fix typo in DateRange docs (yyy → yyyy) (elastic#38883) Introduced class reuses follow parameter code between ShardFollowTasks (elastic#38910) Ensure random timestamps are within search boundary (elastic#38753) [CI] Muting method testFollowIndex in IndexFollowingIT Update Lucene snapshot repo for 7.0.0-beta1 (elastic#38946) SQL: Doc on syntax (identifiers in particular) (elastic#38662) Upgrade to Gradle 5.2.1 (elastic#38880) Tie break search shard iterator comparisons on cluster alias (elastic#38853) Also mmap cfs files for hybridfs (elastic#38940) Build: Fix issue with test status logging (elastic#38799) Adapt FullClusterRestartIT on master (elastic#38856) Fix testAutoFollowing test to use createLeaderIndex() helper method. Migrate muted auto follow rolling upgrade test and unmute this test (elastic#38900) ShardBulkAction ignore primary response on primary (elastic#38901) Recover peers from translog, ignoring soft deletes (elastic#38904) Fix NPE on Stale Index in IndicesService (elastic#38891) Smarter CCR concurrent file chunk fetching (elastic#38841) Fix intermittent failure in ApiKeyIntegTests (elastic#38627) re-enable SmokeTestWatcherWithSecurityIT (elastic#38814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the case of
Descriptionbeing null which is a valid case asdescribed in the
HeartBeatEvent's javadoc, which previously resultedin exceptions that "pollute" the build output.
Follows: #28563