Make 7.x like 6.7 user agent ecs, but default to true (#38757) #38828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change reverts the initial 7.0 commits and replaces them with the 6.7 variant that still allows for the ecs flag. This commit differs from the 6.7 variants in that ecs flag will now default to true. 6.7: `ecs` : default `false` 7.x: `ecs` : default `true` 8.0: no option, but behaves as `true` * Revert "Ingest node - user agent, move device to an object (elastic#38115)" This reverts commit 5b008a3. * Revert "Add ECS schema for user-agent ingest processor (elastic#37727) (elastic#37984)" This reverts commit cac6b8e. * cherry-pick 5dfe193 Add ECS schema for user-agent ingest processor (elastic#37727) * cherry-pick ec8ddc8 Ingest node - user agent, move device to an object (elastic#38115) (elastic#38121) * cherry-pick f63cbdb (with manual merge fixes) Dep. check for ECS changes to User Agent processor (elastic#38362) * make true the default for the ecs option, and update 7.0 references and tests
This was referenced Sep 17, 2021
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
In 8.x, we'll ignore the `ecs` option for the `user_agent` ingest processor. This adds a related breaking change to the 8.0 migration docs. Relates to #38828
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
jrodewig
added a commit
that referenced
this pull request
Sep 21, 2021
We deprecated the `user_agent` ingest processor's `ecs` option in 7.2 with PR #38828. However, we didn't add a related deprecation item to the 7.2 breaking changes docs. This adds the missing item. It also updates a related deprecation admonition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward port of #38757
This change reverts the initial 7.0 commits and replaces them
with the 6.7 variant that still allows for the ecs flag.
This commit differs from the 6.7 variants in that ecs flag will
now default to true.
6.7:
ecs: defaultfalse7.x:
ecs: defaulttrue8.0: no option, but behaves as
trueRevert "Ingest node - user agent, move device to an object (Ingest node - user_agent, move device parsing to an object #38115)"
This reverts commit 5b008a3.
Revert "Add ECS schema for user-agent ingest processor (Add ECS schema for user-agent ingest processor #37727) (Add ECS schema for user-agent ingest processor (#37727) #37984)"
This reverts commit cac6b8e.
cherry-pick 5dfe193
Add ECS schema for user-agent ingest processor (Add ECS schema for user-agent ingest processor #37727)
cherry-pick ec8ddc8
Ingest node - user agent, move device to an object (Ingest node - user_agent, move device parsing to an object #38115) (Ingest node - user agent, move device to an object (#38115) #38121)
cherry-pick f63cbdb (with manual merge fixes)
Dep. check for ECS changes to User Agent processor (Dep. check for ECS changes to User Agent processor #38362)
make true the default for the ecs option, and update 7.0 references and tests