Check that delete index request succeeded in test teardown #38903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: elastic#30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
talevy
approved these changes
Feb 14, 2019
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 14, 2019
…8903) When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: elastic#30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 14, 2019
…8903) When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: elastic#30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 14, 2019
…8903) When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: elastic#30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 14, 2019
* master: Mark coordinator test as awaits fix Check that delete index request succeeded in test teardown (elastic#38903)
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Feb 14, 2019
…8903) When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: elastic#30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
This was referenced Feb 14, 2019
dakrone
added a commit
that referenced
this pull request
Feb 14, 2019
…38913) Backport of #38903 When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: #30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added a commit
that referenced
this pull request
Feb 14, 2019
…38915) Backport of #38903 When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: #30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added a commit
that referenced
this pull request
Feb 14, 2019
…38914) Backport of #38903 When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: #30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
dakrone
added a commit
that referenced
this pull request
Feb 19, 2019
…38916) Backport of #38903 When tearing down from `ESSingleNodeTestCase` we perform a delete on "*" indices, it some cases, however, those indices are not fully deleted. Rather than have a failure occur later down the change (see: #30290 (comment) ) the failure should occurr immediately so it can be diagnosed more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tearing down from
ESSingleNodeTestCasewe perform a delete on "*"indices, it some cases, however, those indices are not fully deleted. Rather
than have a failure occur later down the chain (see:
#30290 (comment) )
the failure should occur immediately so it can be diagnosed more easily.