[Tests] Fix flakiness by ensuring stable cluster #39300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In integration tests where `setBootstrapMasterNodeIndex()` is used in combination with `autoMinMasterNodes = false` the cluster can start bootstrapping once the number of nodes set with the `setBootstrapMasterNodeIndex` have been started but it's not ensured that all nodes have successfully joined to form the cluster. This behaviour was introduced with 5db7ed2 and in order to ensure that the cluster is properly formed before proceeding with the integration test, use `ensureStableCluster()` with the appropriate number of expected nodes. Fixes: elastic#39220
matriv
added
>test-failure
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
approved these changes
Feb 25, 2019
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Good catch @matriv, LGTM with one nit.
|
|
||
| @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/39220") | ||
| public void test3MasterNodes2Failed() throws Exception { | ||
| public void test3MasterNodeRs2Failed() throws Exception { |
Contributor
There was a problem hiding this comment.
Renaming this test looks like it wasn't intended.
Contributor
Author
There was a problem hiding this comment.
ah sorry, didn't see that, thx!
Contributor
Author
|
@andrershov Many thanks for walking me through the bootstrap/discovery process and helping with identifying the issue. |
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 25, 2019
In integration tests where `setBootstrapMasterNodeIndex()` is used in combination with `autoMinMasterNodes = false` the cluster can start bootstrapping once the number of nodes set with the `setBootstrapMasterNodeIndex` have been started but it's not ensured that all nodes have successfully joined to form the cluster. This behaviour was introduced with 5db7ed2 and in order to ensure that the cluster is properly formed before proceeding with the integration test, use `ensureStableCluster()` with the appropriate number of expected nodes. Fixes: elastic#39220
matriv
added a commit
to matriv/elasticsearch
that referenced
this pull request
Feb 25, 2019
In integration tests where `setBootstrapMasterNodeIndex()` is used in combination with `autoMinMasterNodes = false` the cluster can start bootstrapping once the number of nodes set with the `setBootstrapMasterNodeIndex` have been started but it's not ensured that all nodes have successfully joined to form the cluster. This behaviour was introduced with 5db7ed2 and in order to ensure that the cluster is properly formed before proceeding with the integration test, use `ensureStableCluster()` with the appropriate number of expected nodes. Fixes: elastic#39220
matriv
added a commit
that referenced
this pull request
Feb 25, 2019
In integration tests where `setBootstrapMasterNodeIndex()` is used in combination with `autoMinMasterNodes = false` the cluster can start bootstrapping once the number of nodes set with the `setBootstrapMasterNodeIndex` have been started but it's not ensured that all nodes have successfully joined to form the cluster. This behaviour was introduced with 5db7ed2 and in order to ensure that the cluster is properly formed before proceeding with the integration test, use `ensureStableCluster()` with the appropriate number of expected nodes. Fixes: #39220
matriv
added a commit
that referenced
this pull request
Feb 26, 2019
In integration tests where `setBootstrapMasterNodeIndex()` is used in combination with `autoMinMasterNodes = false` the cluster can start bootstrapping once the number of nodes set with the `setBootstrapMasterNodeIndex` have been started but it's not ensured that all nodes have successfully joined to form the cluster. This behaviour was introduced with 5db7ed2 and in order to ensure that the cluster is properly formed before proceeding with the integration test, use `ensureStableCluster()` with the appropriate number of expected nodes. Fixes: #39220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In integration tests where
setBootstrapMasterNodeIndex()is used incombination with
autoMinMasterNodes = falsethe cluster can startbootstrapping once the number of nodes set with the
setBootstrapMasterNodeIndexhave been started, but it's not ensuredthat all nodes have successfully joined to form the cluster.
This behaviour was introduced with 5db7ed2
and in order to ensure that the cluster is properly formed before proceeding
with the integration test, use
ensureStableCluster()with theappropriate number of expected nodes.
Fixes: #39220