Fix Painless def [char] to String casts #39759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>bug
>test
Collaborator
|
Pinging @elastic/es-core-infra |
jdconrad
changed the title
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/default-distro |
Contributor
Author
|
@rjernst Thanks for the review! |
jdconrad
added a commit
that referenced
this pull request
Mar 11, 2019
* Start to fix def char casts. * Fix def char to String casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows def [char] to be explicitly cast to String and def [String] to be explicitly cast to char as per our spec documentation. This also adds appropriate tests and cleans up some of the error messages for def casting.