Blob Store compress default to true #40033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed default of compress setting from false to true for blob store repositories. This aligns the code with documentation and also seems like the better default.
henningandersen
added
>bug
>breaking
:Distributed Coordination/Snapshot/Restore
|
Pinging @elastic/es-distributed |
Adapted test case to new default.
|
@elasticmachine run elasticsearch-ci/1 Failed due to #40030 |
ywelsch
suggested changes
Mar 14, 2019
| ==== Compression of meta data files is now default on | ||
|
|
||
| Previously, the default value for `compress` was `false`. The default has been changed to `true`. This aligns the | ||
| default with documentation. |
There was a problem hiding this comment.
should we change the snapshot docs for 7.x and below to say that the default is false? We can then leave this sentence out.
There was a problem hiding this comment.
Removed that sentence in fd7d5fe and will do a follow-up PR against 7.x
Improved breaking changes documentation.
…ress_default_true
Found more places to change in documentation.
|
@ywelsch please notice the additional documentation changes, the compress option was documented on specific repository types too and here it was stated default false (now changed to true). |
|
@elasticmachine run elasticsearch-ci/2 |
80 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed default of compress setting from false to true for blob store
repositories. This aligns the code with documentation and also seems
like the better default.