-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cluster state size #40061
Merged
jasontedor
merged 4 commits into
elastic:master
from
jasontedor:remove-cluster-state-size
Mar 15, 2019
Merged
Remove cluster state size #40061
jasontedor
merged 4 commits into
elastic:master
from
jasontedor:remove-cluster-state-size
Mar 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the cluster state size field from the cluster state response, and drops the backwards compatibility layer added in 6.7.0 to continue to support this field. As calculation of this field was expensive and had dubious value, we have elected to remove this field.
jasontedor
added
>breaking
v7.0.0
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
v8.0.0
v7.2.0
labels
Mar 14, 2019
Pinging @elastic/es-distributed |
jasontedor
commented
Mar 15, 2019
server/src/main/java/org/elasticsearch/action/admin/cluster/state/ClusterStateResponse.java
Outdated
Show resolved
Hide resolved
…ate/ClusterStateResponse.java
jasontedor
commented
Mar 15, 2019
server/src/main/java/org/elasticsearch/action/admin/cluster/state/ClusterStateResponse.java
Outdated
Show resolved
Hide resolved
…ate/ClusterStateResponse.java
DaveCTurner
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Mar 15, 2019
The `GET /_cluster/state` API returns an internal representation of the cluster state that does change from version to version. It's useful for debugging, but it is not intended for regular use by clients. This change adjusts the documentation of `GET /_cluster/state` to clarify that this API yields an internal representation that should not be expected to remain stable between versions. Relates elastic#40061, elastic#40016
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 15, 2019
This commit removes the cluster state size field from the cluster state response, and drops the backwards compatibility layer added in 6.7.0 to continue to support this field. As calculation of this field was expensive and had dubious value, we have elected to remove this field.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 15, 2019
This commit removes the cluster state size field from the cluster state response, and drops the backwards compatibility layer added in 6.7.0 to continue to support this field. As calculation of this field was expensive and had dubious value, we have elected to remove this field.
DaveCTurner
added a commit
that referenced
this pull request
Mar 18, 2019
The `GET /_cluster/state` API returns an internal representation of the cluster state that does change from version to version. It's useful for debugging, but it is not intended for regular use by clients. This change adjusts the documentation of `GET /_cluster/state` to clarify that this API yields an internal representation that should not be expected to remain stable between versions. Relates #40061, #40016
DaveCTurner
added a commit
that referenced
this pull request
Mar 18, 2019
The `GET /_cluster/state` API returns an internal representation of the cluster state that does change from version to version. It's useful for debugging, but it is not intended for regular use by clients. This change adjusts the documentation of `GET /_cluster/state` to clarify that this API yields an internal representation that should not be expected to remain stable between versions. Relates #40061, #40016
DaveCTurner
added a commit
that referenced
this pull request
Mar 18, 2019
The `GET /_cluster/state` API returns an internal representation of the cluster state that does change from version to version. It's useful for debugging, but it is not intended for regular use by clients. This change adjusts the documentation of `GET /_cluster/state` to clarify that this API yields an internal representation that should not be expected to remain stable between versions. Relates #40061, #40016
DaveCTurner
added a commit
that referenced
this pull request
Mar 18, 2019
The `GET /_cluster/state` API returns an internal representation of the cluster state that does change from version to version. It's useful for debugging, but it is not intended for regular use by clients. This change adjusts the documentation of `GET /_cluster/state` to clarify that this API yields an internal representation that should not be expected to remain stable between versions. Relates #40061, #40016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>breaking
:Distributed Indexing/Distributed
A catch all label for anything in the Distributed Area. Please avoid if you can.
v7.0.0-rc1
v7.2.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the cluster state size field from the cluster state response, and drops the backwards compatibility layer added in 6.7.0 to continue to support this field. As calculation of this field was expensive and had dubious value, we have elected to remove this field.
Relates #39806
Relates #39827
Relates #39951
Relates #40016