Remove Migration Upgrade and Assistance APIs #40075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Migration Assistance API has been functionally replaced by the Deprecation Info API, and the Migration Upgrade API is not used for the transition from ES 6.x to 7.x, and does not need to be kept around to repair indices that were not properly upgraded before upgrading the cluster, as was the case in 6. These APIs are deprecated in 6.7 and this commit removes them.
|
Pinging @elastic/es-core-features |
gwbrown
changed the title
|
@jakelandis could you also take a look at the changes in 4a8b69f as I had to modify a couple BWC tests? The changes basically just make the test fail if the index needs to be upgraded, which should not happen at any point going 6->7->8 unless we make a change that would make reinstating the Upgrade API necessary. |
|
Still LGTM |
|
I opened #40116 about the CI failure, which does not appear to be related to the changes here. @elasticmachine run elasticsearch-ci/2 |
|
Thanks for the second review @jakelandis! |
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 15, 2019
The Migration Assistance API has been functionally replaced by the Deprecation Info API, and the Migration Upgrade API is not used for the transition from ES 6.x to 7.x, and does not need to be kept around to repair indices that were not properly upgraded before upgrading the cluster, as was the case in 6.
gwbrown
added a commit
to gwbrown/elasticsearch
that referenced
this pull request
Mar 15, 2019
The Migration Assistance API has been functionally replaced by the Deprecation Info API, and the Migration Upgrade API is not used for the transition from ES 6.x to 7.x, and does not need to be kept around to repair indices that were not properly upgraded before upgrading the cluster, as was the case in 6.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 16, 2019
…te-size-hard-failure * elastic/master: use shell with JAVA_HOME for starting archive (elastic#40118) Remove Migration Upgrade and Assistance APIs (elastic#40075) Revert "Fix IndexSearcherWrapper visibility (elastic#39071)" Remove transport name from tcp channel (elastic#40074) Document the limitation around field aliases and percolator. (elastic#40073) SQL: Refactor Literals serialization method (elastic#40058)
gwbrown
added a commit
that referenced
this pull request
Mar 18, 2019
The Migration Assistance API has been functionally replaced by the Deprecation Info API, and the Migration Upgrade API is not used for the transition from ES 6.x to 7.x, and does not need to be kept around to repair indices that were not properly upgraded before upgrading the cluster, as was the case in 6.
gwbrown
added a commit
that referenced
this pull request
Mar 18, 2019
The Migration Assistance API has been functionally replaced by the Deprecation Info API, and the Migration Upgrade API is not used for the transition from ES 6.x to 7.x, and does not need to be kept around to repair indices that were not properly upgraded before upgrading the cluster, as was the case in 6.
16 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 20, 2019
Mpdreamz
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jun 20, 2019
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 17, 2020
These actions were almost completely removed in elastic#40075 but a couple of classes were left in place. This commit completes their removal.
DaveCTurner
added a commit
that referenced
this pull request
Sep 18, 2020
These actions were almost completely removed in #40075 but a couple of classes were left in place. This commit completes their removal.
DaveCTurner
added a commit
that referenced
this pull request
Sep 18, 2020
These actions were almost completely removed in #40075 but a couple of classes were left in place. This commit completes their removal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Migration Assistance API has been functionally replaced by the
Deprecation Info API, and the Migration Upgrade API is not used for the
transition from ES 6.x to 7.x, and does not need to be kept around to
repair indices that were not properly upgraded before upgrading the
cluster, as was the case in 6.
These APIs are deprecated in 6.7 and this commit removes them.
Follow-up to to #40072
Relates to #40014