-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Document limits for JSON objects with ignore_malformed
mapping setting
#40976
[DOCS] Document limits for JSON objects with ignore_malformed
mapping setting
#40976
Conversation
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change says:
You can't use
ignore_malformed
to index JSON objects into field datatypes used
for other data formats, liketext
orinteger
.
ignore_malformed
isn't used to index values. As the docs currently indicate:
The ignore_malformed parameter, if set to true, allows the exception to be ignored. The malformed field is not indexed, but other fields in the document are processed normally.
Thus, this should be something more like:
You can't use `ignore_malformed` to ignore JSON objects submitted for indexing against fields that were not mapped as objects, nested objects, or ranges. The field will not be ignored, the document will not be indexed, and instead an error will be returned for the indexing request.
I don't know whether this limitation is restricted to object, nested object, and range mappings, or whether there are any additional types for which this should be documented.
Thanks for your feedback @bczifra. I particularly appreciate you catching that use of In 99f135d, I revised the section to highlight:
I did some testing in 6.7 and confirmed the following with @jimczi:
|
@jrodewig the changed text is great! Thanks for clarifying this! |
@bczifra When convenient and if you approve, do you mind changing your review status from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As of this writing,
ignore_malformed
has two undocumented limits for JSON objects:ignore_malformed
does not support datatypes intended for JSON objects, likerange
orobject
ignore_malformed
for any JSON data format except JSON objectsThis documents those limits. As #12366 notes, support for JSON objects may be added later. We can remove this section then.
Resolves #36464.