Docs: Fix rendering of APIs that mention version #41154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rendering the `version_qualified` attribute in the docs. This attribute includes `-SNAPSHOT` but does not include `-alpha` or `-beta` and represents the `version` field as returned by `GET /` or `GET /_cat/plugins`. Without this change we just drop the entire line on the floor rather than render it so the output looks bad.
|
Relates to #41128. I noticed it first with the plugins and integrations book but it comes up in the reference as well. |
jrodewig
approved these changes
Apr 12, 2019
There was a problem hiding this comment.
👍 LGTM and successfully builds.
Fixes the snippet on the cat plugins page:
|
Thanks for reviewing @jrodewig ! |
nik9000
added a commit
that referenced
this pull request
Apr 12, 2019
Fixes rendering the `version_qualified` attribute in the docs. This attribute includes `-SNAPSHOT` but does not include `-alpha` or `-beta` and represents the `version` field as returned by `GET /` or `GET /_cat/plugins`. Without this change we just drop the entire line on the floor rather than render it so the output looks bad.
nik9000
added a commit
that referenced
this pull request
Apr 12, 2019
Fixes rendering the `version_qualified` attribute in the docs. This attribute includes `-SNAPSHOT` but does not include `-alpha` or `-beta` and represents the `version` field as returned by `GET /` or `GET /_cat/plugins`. Without this change we just drop the entire line on the floor rather than render it so the output looks bad.
nik9000
added a commit
that referenced
this pull request
Apr 12, 2019
Fixes rendering the `version_qualified` attribute in the docs. This attribute includes `-SNAPSHOT` but does not include `-alpha` or `-beta` and represents the `version` field as returned by `GET /` or `GET /_cat/plugins`. Without this change we just drop the entire line on the floor rather than render it so the output looks bad.
nik9000
added a commit
that referenced
this pull request
Apr 12, 2019
This reverts commit 2ff1815. It turns out we don't need it in 6.x.
|
Backport complete! |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Fixes rendering the `version_qualified` attribute in the docs. This attribute includes `-SNAPSHOT` but does not include `-alpha` or `-beta` and represents the `version` field as returned by `GET /` or `GET /_cat/plugins`. Without this change we just drop the entire line on the floor rather than render it so the output looks bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rendering the
version_qualifiedattribute in the docs. Thisattribute includes
-SNAPSHOTbut does not include-alphaor-betaand represents the
versionfield as returned byGET /orGET /_cat/plugins. Without this change we just drop the entire line onthe floor rather than render it so the output looks bad.