Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up outdated skip statements in yaml tests #41165

Merged
merged 9 commits into from
Apr 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@

---
"standard_html_strip":
- skip:
version: " - 6.99.99"
reason: only starting from version 7.x this throws an error
- do:
catch: /\[standard_html_strip\] analyzer is not supported for new indices, use a custom analyzer using \[standard\] tokenizer and \[html_strip\] char_filter, plus \[lowercase\] filter/
indices.analyze:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@

---
"ngram_exception":
- skip:
version: " - 6.99.99"
reason: only starting from version 7.x this throws an error
- do:
catch: /The difference between max_gram and min_gram in NGram Tokenizer must be less than or equal to[:] \[1\] but was \[2\]\. This limit can be set by changing the \[index.max_ngram_diff\] index level setting\./
indices.analyze:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1137,10 +1137,6 @@

---
"delimited_payload_filter_error":
- skip:
version: " - 6.99.99"
reason: using delimited_payload_filter throws error from 7.0 on

- do:
catch: /\[delimited_payload_filter\] is not supported for new indices, use \[delimited_payload\] instead/
indices.create:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
---
"htmlStrip_deprecated":
- skip:
version: " - 6.2.99"
reason: deprecated in 6.3
reason: deprecated
features: "warnings"

- do:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,6 @@

---
"Test with new response format":
- skip:
version: " - 6.99.99"
reason: hits.total is returned as an object in 7.0.0

- do:
index:
index: test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,6 @@ setup:

---
"Test with rest_total_hits_as_int":
- skip:
version: " - 6.99.99"
reason: hits.total is returned as an object in 7.0.0

- do:
put_script:
id: stored_template_1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -452,10 +452,6 @@
---

"Exception on negative score":
- skip:
version: " - 6.99.99"
reason: "check on negative scores was added from 7.0.0 on"

- do:
index:
index: test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# Sanity integration test to make sure the custom context and whitelist work for moving_fn pipeline agg
#
setup:
- skip:
version: " - 6.3.99"
reason: "moving_fn added in 6.4.0"
- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
# Integration tests for ScriptScoreQuery using Painless

setup:
- skip:
version: " - 6.99.99"
reason: "script score query was introduced in 7.0.0"

---
"Math functions":
- do:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
setup:
- skip:
version: " - 6.99.99"
reason: "Implemented in 7.0"

- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
setup:
- skip:
version: " - 6.99.99"
reason: "The rank feature field/query was introduced in 7.0.0"

- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
setup:
- skip:
version: " - 6.99.99"
reason: "The rank_features field was introduced in 7.0.0"

- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Test percolator basics via rest":

- skip:
version: " - 6.99.99"
reason: types are required in requests before 7.0.0

- do:
indices.create:
index: queries_index
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ setup:

---
"Response format":

- skip:
version: " - 6.2.99"
reason: response format was updated in 6.3

- do:
rank_eval:
index: foo,
Expand Down Expand Up @@ -120,11 +115,6 @@ setup:

---
"Mean Reciprocal Rank":

- skip:
version: " - 6.2.99"
reason: response format was updated in 6.3

- do:
rank_eval:
body: {
Expand Down Expand Up @@ -159,11 +149,6 @@ setup:

---
"Expected Reciprocal Rank":

- skip:
version: " - 6.3.99"
reason: ERR was introduced in 6.4

- do:
rank_eval:
body: {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Response format":

- skip:
version: " - 6.1.99"
reason: the ranking evaluation feature is available since 6.2

- do:
index:
index: foo
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Response format":

- skip:
version: " - 6.2.99"
reason: response format was updated in 6.3

- do:
index:
index: foo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ setup:

---
"Basic rank-eval request with template":

- skip:
version: " - 6.1.99"
reason: the ranking evaluation feature is available since 6.2

- do:
rank_eval:
body: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@

---
"Response for version conflict (seq no powered)":
- skip:
version: " - 6.6.99"
reason: reindex moved to rely on sequence numbers for concurrency control

- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@

---
"Response for version conflict (seq no powered)":
- skip:
version: " - 6.6.99"
reason: reindex moved to rely on sequence numbers for concurrency control
- do:
indices.create:
index: test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
---
"Normalization with deprecated unicodeSetFilter":
- skip:
version: " - 6.99.99"
reason: unicodeSetFilter deprecated in 7.0.0, replaced by unicode_set_filter
features: "warnings"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@

---
"annotated highlighter on annotated text":
- skip:
version: " - 6.4.99"
reason: Annotated text type introduced in 6.5.0

- do:
indices.create:
index: annotated
Expand Down Expand Up @@ -45,10 +41,6 @@

---
"issue 39395 thread safety issue -requires multiple calls to reveal":
- skip:
version: " - 6.4.99"
reason: Annotated text type introduced in 6.5.0

- do:
indices.create:
index: annotated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,6 @@

---
"skip_unavailable is returned as part of _remote/info response":
- skip:
version: " - 6.0.99"
reason: "skip_unavailable is only returned from 6.1.0 on"

- do:
cluster.get_settings:
include_defaults: true
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Test with date processor":
- skip:
version: " - 6.9.99"
reason: pre-7.0.0 requires the 8 prefix for Java time formats, so would treat the format in this test as a Joda time format
features: "warnings"

- do:
ingest.put_pipeline:
id: "_id"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
---
"Deprecated parameters should fail in Bulk query":

- skip:
version: " - 6.99.99"
reason: some parameters are removed starting from 7.0, their equivalents without underscore are used instead
features: "warnings"

- do:
catch: bad_request
bulk:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Compare And Swap Sequence Numbers":

- skip:
version: " - 6.99.99"
reason: typeless API are add in 7.0.0

- do:
index:
index: test_1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Compare And Swap Sequence Numbers":

- skip:
version: " - 6.99.99"
reason: typesless api was introduces in 7.0

- do:
index:
index: test_1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Index with typeless API on an index that has types":

- skip:
version: " - 6.99.99"
reason: Typeless APIs were introduced in 7.0.0

- do:
indices.create: # not using include_type_name: false on purpose
include_type_name: true
Expand Down Expand Up @@ -64,11 +59,6 @@

---
"Index call that introduces new field mappings":

- skip:
version: " - 6.99.99"
reason: Typeless APIs were introduced in 7.0.0

- do:
indices.create: # not using include_type_name: false on purpose
include_type_name: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@

---
"clear_cache with fielddata set to true":
- skip:
version: " - 6.2.99"
reason: fielddata was deprecated before 6.3.0

- do:
indices.clear_cache:
fielddata: true
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
---
"Create a typeless index while there is a typed template":

- skip:
version: " - 6.6.99"
reason: Merging typeless/typed mappings/templates was added in 6.7

- do:
indices.put_template:
include_type_name: true
Expand Down Expand Up @@ -38,11 +33,6 @@

---
"Create a typed index while there is a typeless template":

- skip:
version: " - 6.6.99"
reason: Merging typeless/typed mappings/templates was added in 6.7

- do:
indices.put_template:
include_type_name: false
Expand Down Expand Up @@ -77,11 +67,6 @@

---
"Implicitly create a typed index while there is a typeless template":

- skip:
version: " - 6.99.99"
reason: include_type_name only supported as of 6.7

- do:
indices.put_template:
include_type_name: false
Expand All @@ -102,11 +87,6 @@

---
"Implicitly create a typeless index while there is a typed template":

- skip:
version: " - 6.99.99"
reason: needs typeless index operations to work on typed indices

- do:
indices.put_template:
include_type_name: true
Expand Down
Loading