-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove inline callouts in SQL Command docs for Asciidoctor migration #41276
[DOCS] Remove inline callouts in SQL Command docs for Asciidoctor migration #41276
Conversation
Pinging @elastic/es-docs |
Pinging @elastic/es-search |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
DESCRIBE [table identifier<1> | [LIKE pattern<2>]] | ||
DESCRIBE | ||
[table identifier | <1> | ||
[LIKE pattern]] <2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd probably vertically align these but it isn't a big deal either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Still LGTM. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Removes inline callouts from the SQL Commands documentation. This change helps prepare Elasticsearch docs for Asciidoctor migration.
Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."
Relates to #41128
Before / After Rendering
DESCRIBE TABLE
Before
![describe-before](https://user-images.githubusercontent.com/40268737/56246914-12c80e00-6058-11e9-8eb2-07aa7837c9d1.png)
After
![Screen Shot 2019-04-17 at 6 29 15 AM](https://user-images.githubusercontent.com/40268737/56291460-287e1780-60da-11e9-8d09-1acae41f4e29.png)
SHOW COLUMNS
Before
![show-columns-before](https://user-images.githubusercontent.com/40268737/56246987-40ad5280-6058-11e9-8e88-bea13d664821.png)
After
![Screen Shot 2019-04-17 at 6 29 52 AM](https://user-images.githubusercontent.com/40268737/56291495-3d5aab00-60da-11e9-98a7-d5098a394add.png)
SHOW FUNCTIONS
Before
![show-functions-before](https://user-images.githubusercontent.com/40268737/56247025-5cb0f400-6058-11e9-9bdd-249609f1b633.png)
After
![Screen Shot 2019-04-17 at 6 37 20 AM](https://user-images.githubusercontent.com/40268737/56292057-4ac46500-60db-11e9-8c19-f8beae152f6b.png)
SHOW TABLES
Before
![show-tables-before](https://user-images.githubusercontent.com/40268737/56247063-79e5c280-6058-11e9-8214-a00a922d9a80.png)
After
![Screen Shot 2019-04-17 at 6 31 28 AM](https://user-images.githubusercontent.com/40268737/56291632-772bb180-60da-11e9-8a91-348226c03188.png)