Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove inline callouts in SQL Functions/Operators docs for Asciidoctor migration #41309

Merged
merged 1 commit into from
Apr 22, 2019
Merged

[DOCS] Remove inline callouts in SQL Functions/Operators docs for Asciidoctor migration #41309

merged 1 commit into from
Apr 22, 2019

Conversation

jrodewig
Copy link
Contributor

Removes remaining inline callouts from the SQL Functions and Operators documentation. This change helps prepare Elasticsearch docs for Asciidoctor migration.

Per https://asciidoctor.org/docs/user-manual/#callouts, AsciiDoctor enforces this requirement: "The callout number (at the target) must be placed at the end of the line."

Relates to #41128

Before / After Images

LIKE and RLIKE Operators

Before
like-rlike-before

After
like-rlike-after

Aggregate Functions

Before
aggs-before

After
aggs-after

Grouping Functions

Before
grouping-before

After
grouping-after

Date/Time and Interval Functions and Operators

Before
date-time-before

After
date-time-after

Full-Text Search Functions

Before
search-before

After
search-after

Mathematical Functions

Before
math-before

After
math-after

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too. Thanks for fixing all these!

@jrodewig jrodewig merged commit 9982888 into elastic:master Apr 22, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors-sql-functions branch April 22, 2019 13:34
jrodewig added a commit that referenced this pull request Apr 22, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants