Make sure to apply eager_global_ordinals for keyed JSON fields. #41319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index warmer iterates through all field types when determining the fields for which global ordinals should be loaded. Previously, keyed JSON field types were not returned from FieldTypeLookup#iterator, so their eager_global_ordinals setting would be ignored. This PR fixes the issue by including keyed JSON fields in FieldTypeLookup#iterator.
jtibshirani
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
11 tasks
jtibshirani
force-pushed
the
eager-global-ordinals
branch
from
427b109
to
5eb82b1
Compare
jtibshirani
changed the title
jtibshirani
changed the title
jpountz
approved these changes
Apr 18, 2019
jtibshirani
added a commit
that referenced
this pull request
May 1, 2019
…r. (#41319) The index warmer iterates through all field types when determining the fields for which global ordinals should be loaded. Previously, keyed JSON field types were not returned from FieldTypeLookup#iterator, so their eager_global_ordinals setting would be ignored. This PR fixes the issue by including keyed JSON fields in FieldTypeLookup#iterator.
jtibshirani
added a commit
that referenced
this pull request
May 24, 2019
…r. (#41319) The index warmer iterates through all field types when determining the fields for which global ordinals should be loaded. Previously, keyed JSON field types were not returned from FieldTypeLookup#iterator, so their eager_global_ordinals setting would be ignored. This PR fixes the issue by including keyed JSON fields in FieldTypeLookup#iterator.
jtibshirani
commented
May 29, 2019
| if (fullNameToJsonMapper.isEmpty()) { | ||
| return concreteFieldTypes; | ||
| } else { | ||
| Iterator<MappedFieldType> keyedJsonFieldTypes = fullNameToJsonMapper.values().stream() |
There was a problem hiding this comment.
A note for future reference: the other option would have been to expose the field type by adding a 'keyed' field mapper in JsonFieldMapper#iterator. I didn't go down that path because this would make my_json_field._keyed a valid field to search on, which we want to avoid.
jtibshirani
added a commit
that referenced
this pull request
May 29, 2019
…r. (#41319) The index warmer iterates through all field types when determining the fields for which global ordinals should be loaded. Previously, keyed JSON field types were not returned from FieldTypeLookup#iterator, so their eager_global_ordinals setting would be ignored. This PR fixes the issue by including keyed JSON fields in FieldTypeLookup#iterator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index warmer iterates through all field types when determining the fields
for which global ordinals should be loaded. Previously, keyed JSON field types
were not returned from
FieldTypeLookup#iterator, so theireager_global_ordinalssetting would be ignored. This PR fixes the issue by including keyed JSON fields
in
FieldTypeLookup#iterator.