Use collections conveniences in static initializers #41374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces the construction of some collections in static initializers with new collection convenience methods that are available now that we have bumped the minimum Java language level to be higher than Java 8.
jasontedor
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jpountz
approved these changes
Apr 19, 2019
| @@ -128,13 +123,13 @@ private QueryAnalyzer() { | |||
| * @param indexVersion The create version of the index containing the percolator queries. | |||
| */ | |||
| static Result analyze(Query query, Version indexVersion) { | |||
| Class<?> queryClass = query.getClass(); | |||
| Class<? extends Query> queryClass = query.getClass(); | |||
There was a problem hiding this comment.
I think this is creating more problems than it helps?
| @@ -99,7 +99,11 @@ private Sets() { | |||
| public static <T> SortedSet<T> sortedDifference(Set<T> left, Set<T> right) { | |||
There was a problem hiding this comment.
Not directly related to you change, but I'm seeing some inconsistencies wrt whether the return value of this method is assumed mutable. Reconfigurator seems to assume it is immutable and creates a TreeSet out of it while RestGetMappingAction modidies the result of this method. The reason why I was looking at this was to figure out whether we should actually have a toSortedSet method in this class, or whether what we actually needed was a toUnmodifiableSortedSet.
jpountz
approved these changes
Apr 19, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This commit replaces the construction of some collections in static initializers with new collection convenience methods that are available now that we have bumped the minimum Java language level to be higher than Java 8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces the construction of some collections in static initializers with new collection convenience methods that are available now that we have bumped the minimum Java language level to be higher than Java 8.