Docs: Rework close ml section #41435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! I didn't see that failure locally. |
Reworks the close ml section to work properly in Asciidoctor. It renders a little funny in AsciiDoc but AsciiDoc is on its way out anyway....
|
I didn't commit one part of my original change..... |
|
OOh. That extra +.... |
Oh well. I can live with it for the next few days until we do the conversion. I'm hoping it'll be days. |
nik9000
added a commit
that referenced
this pull request
Apr 23, 2019
Reworks the close ml section to work properly in Asciidoctor. It renders a little funny in AsciiDoc but AsciiDoc is on its way out anyway....
nik9000
added a commit
that referenced
this pull request
Apr 23, 2019
Reworks the close ml section to work properly in Asciidoctor. It renders a little funny in AsciiDoc but AsciiDoc is on its way out anyway....
|
I've backported this. master and 7.0 can now be built with asciidoctor. 7.x is still busted. I'll see if I can fix it. |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Reworks the close ml section to work properly in Asciidoctor. It renders a little funny in AsciiDoc but AsciiDoc is on its way out anyway....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the close ml section to work properly in Asciidoctor. It
renders a little funny in AsciiDoc but AsciiDoc is on its way out
anyway....
Relates to #41128