Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Specify two IDs in migration docs #41501

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented Apr 24, 2019

We link to these migraiton docs but we don't specify the id. This
isn't great practice in general and is preventing us from migrating to
Asciidoctor because it generates ids in a slightly different way.

We link to these migraiton docs but we don't specify the id. This
isn't great practice in general and is preventing us from migrating to
Asciidoctor because it generates ids in a slightly different way.
@nik9000 nik9000 requested a review from jrodewig April 24, 2019 18:23
@nik9000 nik9000 changed the title Docs: Specify an ID in migration docs Docs: Specify two IDs in migration docs Apr 24, 2019
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and builds successfully

@nik9000 nik9000 merged commit bb6ca25 into elastic:7.x Apr 24, 2019
nik9000 added a commit that referenced this pull request Apr 24, 2019
We link to these migraiton docs but we don't specify the id. This
isn't great practice in general and is preventing us from migrating to
Asciidoctor because it generates ids in a slightly different way.
@jaymode jaymode added >docs General docs changes >non-issue labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants