Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Specify ID to prepare for Asciidoctor migration #41512

Merged
merged 1 commit into from
Apr 25, 2019
Merged

[DOCS] Specify ID to prepare for Asciidoctor migration #41512

merged 1 commit into from
Apr 25, 2019

Conversation

jrodewig
Copy link
Contributor

From 5.6 to 6.5, a snippet on the Deprecation info APIs page contained a link with an autogenerated anchor to a 6.0 Breaking Change page.

This is bad practice generally, but the link breaks in Asciidoctor. This PR adds the anchor to so the link does not break during Asciidoctor migration.

Relates to #41128 and elastic/docs#827.

@jrodewig jrodewig added >docs General docs changes :Docs labels Apr 24, 2019
@jrodewig jrodewig requested a review from nik9000 April 24, 2019 23:02
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig jrodewig merged commit be7b36b into elastic:6.0 Apr 25, 2019
@jrodewig jrodewig deleted the fix-asciidoctor-errors-index-patterns branch April 25, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants