Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Explicitly set section IDs for Asciidoctor migration #41547

Merged
merged 2 commits into from
Apr 25, 2019
Merged

[DOCS] Explicitly set section IDs for Asciidoctor migration #41547

merged 2 commits into from
Apr 25, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 25, 2019

The following page URLs contain autogenerated IDs:

With the Asciidoctor migration, these IDs would change and result in broken links.

This explicitly sets the IDs so the page URLs are stable during Asciidoctor migration. It also adds a redirect for any users that have bookmarked the old URLs.

I plan to backport this to 7.0. Relates to #41128 and elastic/docs#827.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@jrodewig jrodewig changed the title [DOCS] Explicitly set section ID for Asciidoctor migration [DOCS] Explicitly set section IDs for Asciidoctor migration Apr 25, 2019
@@ -594,3 +594,11 @@ formation module>>.
=== {xpack} settings in {es}

include::{asciidoc-dir}/../../shared/settings.asciidoc[]

[role="exclude",id="_faster_phrase_queries_with_literal_index_phrases_literal"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrodewig jrodewig merged commit bb62bc6 into elastic:master Apr 25, 2019
jrodewig added a commit that referenced this pull request Apr 25, 2019
* [DOCS] Explicitly set section ID for faster phrase queries

* [DOCS] Explicitly set section ID for faster prefix queries
jrodewig added a commit that referenced this pull request Apr 25, 2019
* [DOCS] Explicitly set section ID for faster phrase queries

* [DOCS] Explicitly set section ID for faster prefix queries
@jrodewig jrodewig deleted the asciidoctor-fix-section-ids branch April 25, 2019 19:08
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 26, 2019
…s-in-all-the-places

* elastic/master: (70 commits)
  Remove experimental label froms script_score query (elastic#41572)
  [Ml-Dataframe] Update URLs in Data frame client java doc (elastic#41539)
  Reenable bwc Tests in master (elastic#41540)
  Fix search_as_you_type's sub-fields to pick their names from the full path of the root field (elastic#41541)
  Remove search analyzers from DocumentFieldMappers (elastic#41484)
  Update community client and integration docs (elastic#41513)
  Remove Version.V_6_x_x constants use in security (elastic#41185)
  Mute testDriverConfigurationWithSSLInURL
  Remove dedicated SSL network write buffer (elastic#41283)
  Disable max score optimization for queries with unbounded max scores (elastic#41361)
  [DOCS] Explicitly set section IDs for Asciidoctor migration (elastic#41547)
  [ML] add multi node integ tests for data frames (elastic#41508)
  [Docs] Fix common word repetitions (elastic#39703)
  [DOCS] Note TESTRESPONSE can't be used immediately after TESTSETUP (elastic#41542)
  Update configuring-ldap-realm.asciidoc (elastic#40427)
  Fixed very small typo in date (elastic#41398)
  Refactor GeoHashUtils (elastic#40869)
  Make 0 as invalid value for `min_children` in `has_child` query (elastic#41347)
  field_caps: adapt bwc version after backport (elastic#41427)
  Remove Exists Check from S3 Repository Deletes (elastic#40931)
  ...
@jaymode jaymode added v7.0.1 and removed v7.0.2 labels Apr 29, 2019
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
…41547)

* [DOCS] Explicitly set section ID for faster phrase queries

* [DOCS] Explicitly set section ID for faster prefix queries
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
…41547)

* [DOCS] Explicitly set section ID for faster phrase queries

* [DOCS] Explicitly set section ID for faster prefix queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants