-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add space to fix Asciidoctor output #41579
[DOCS] Add space to fix Asciidoctor output #41579
Conversation
@@ -607,7 +607,7 @@ M |57 | |||
groupByAndAggExpression | |||
// tag::groupByAndAggExpression | |||
schema::g:s|salary:i | |||
SELECT gender AS g, ROUND((MIN(salary) / 100)) AS salary FROM emp GROUP BY gender; | |||
SELECT gender AS g, ROUND( (MIN(salary) / 100) ) AS salary FROM emp GROUP BY gender; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is in the file called docs.csv-spec
but I'm worried that folks will remove the spacing without realizing the change that it makes in the docs. I wonder if there is a better way to change this. Let me look around some!
Pinging @elastic/es-docs |
This failure is caused because we use the +ifdef::asciidoctor[]
+[source,sql]
+endif::[]
+ifndef::asciidoctor[]
["source","sql",subs="attributes,callouts,macros"]
+endif::[] This suggests that we probably should remove Now that I understand it I'm fine with either fix so long as we make sure to blast |
Asciidoctor outputs
((MIN(salary) / 100))
as<indexterm><primary>MIN(salary) / 100</primary></indexterm>
. This adds whitespace to correct the output in preparation for the Asciidoctor migration.Relates to elastic/docs#827 and #41128.