-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Remove soft line breaks (+) for Asciidoctor migration #41600
Merged
jrodewig
merged 1 commit into
elastic:master
from
jrodewig:asciidoctor-monitor-collectors
Apr 30, 2019
Merged
[DOCS] Remove soft line breaks (+) for Asciidoctor migration #41600
jrodewig
merged 1 commit into
elastic:master
from
jrodewig:asciidoctor-monitor-collectors
Apr 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-docs |
nik9000
approved these changes
Apr 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh.
I think you could try sticking an a
in the table as documented here to get it to render. It might work!
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
jrodewig
added a commit
that referenced
this pull request
Apr 30, 2019
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tables, Asciidoctor renders soft line breaks (
+
) literally. As it turns out, our current Asciidoc output did not honor the soft line breaks anyway.This removes the soft line breaks (
+
) to prepare for Asciidoctor migration. It also joins and rewraps the existing content. It contains no substantive changes.Relates to elastic/docs#827
Current production output (AsciiDoc)
Asciidoctor output before changes
Asciidoctor output after changes