Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove soft line breaks (+) for Asciidoctor migration #41600

Merged
merged 1 commit into from
Apr 30, 2019
Merged

[DOCS] Remove soft line breaks (+) for Asciidoctor migration #41600

merged 1 commit into from
Apr 30, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Apr 26, 2019

In tables, Asciidoctor renders soft line breaks (+) literally. As it turns out, our current Asciidoc output did not honor the soft line breaks anyway.

This removes the soft line breaks (+) to prepare for Asciidoctor migration. It also joins and rewraps the existing content. It contains no substantive changes.

Relates to elastic/docs#827

Current production output (AsciiDoc)

Current-production

Asciidoctor output before changes

Asciidoctor-before-changes

Asciidoctor output after changes

Asciidoctor-after

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh.

I think you could try sticking an a in the table as documented here to get it to render. It might work!

@jrodewig
Copy link
Contributor Author

Thanks for the suggestion. I gave [cols=",,a"] a try. Here was how it rendered.

screencapture-localhost-8000-es-monitoring-collectors-html-2019-04-30-16_20_03

@jrodewig jrodewig merged commit 9a8d976 into elastic:master Apr 30, 2019
@jrodewig jrodewig deleted the asciidoctor-monitor-collectors branch April 30, 2019 20:22
akhil10x5 pushed a commit to akhil10x5/elasticsearch that referenced this pull request May 2, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants