Cut AnalyzeResponse over to Writeable #41915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Relevance/Analysis
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
I started to look at AnalysisRequest as well, but that's going to be a bigger change, partially because it's used in the HLRC and so making things immutable will be a breaking change for clients. |
Contributor
There was a problem hiding this comment.
should we make the fields name and texts final ?
Contributor
There was a problem hiding this comment.
should we make name and tokens fields to be final?
romseygeek
force-pushed
the
analyze-writeable
branch
from
1aaa532 to
6e7c8e4
Compare
Contributor
Author
|
@elasticmachine run elasticsearch-ci/docbldesx |
mayya-sharipova
approved these changes
May 8, 2019
Contributor
mayya-sharipova
left a comment
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @romseygeek
talevy
reviewed
May 8, 2019
| @Deprecated | ||
| protected abstract Response newResponse(); | ||
|
|
||
| protected Writeable.Reader<Response> getResponseReader() { |
Contributor
There was a problem hiding this comment.
thanks for this @romseygeek!
I tried my hand at a follow-up to remove the adapter for this here #41985.
romseygeek
added a commit
that referenced
this pull request
May 9, 2019
This commit makes AnalyzeResponse and its various helper classes implement Writeable. The classes are also now immutable. Relates to #34389
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
This commit makes AnalyzeResponse and its various helper classes implement Writeable. The classes are also now immutable. Relates to elastic#34389
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes AnalyzeResponse and its various helper classes implement
Writeable. The classes are also now immutable.
Relates to #34389