Reindex remove outer level size #43373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit finalizes the work done to rename `size` to `max_docs` in reindex and update/delete by query. `size` is no longer supported in URL or outer level body for the 3 APIs. Continuation of elastic#41894 Closes elastic#24344
henningandersen
added
>enhancement
v8.0.0
:Distributed Indexing/Reindex
|
Pinging @elastic/es-distributed |
Update and delete by query calls from rest-high-level-client generate size in the body (meaning scroll size). Given that size in body for these two requests has always meant scroll-size, there is no reason to tighten that in this PR, so removing those checks. Also, this ensures that rest-high-level-client requests generated with 7.x codebase works against 8.0.
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
Feb 16, 2021
The commit elastic#43373 has removed outer level size field in version 7. This commit allows for the use of the size field in server ES8 using compatible REST API. relates elastic#51816
jakelandis
added a commit
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: #43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Nov 8, 2021
This commit fixes a documentation bug that lists 'max_docs' nested under source it should live at the same level as source related: elastic#43373
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit finalizes the work done to rename
sizetomax_docsinreindex and update/delete by query.
sizeis no longer supported in URLor outer level body for the 3 APIs (though
sizein update/delete-by-querywill and has always been interpreted as
scroll_size, it is not to be reliedupon).
Continuation of #41894
Closes #24344