Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate linearizability check early on large histories #44444

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jul 16, 2019

Large histories can be problematic and have the linearizability checker occasionally run OOM. As it's very difficult to bound the size of the histories just right, this PR will let it instead run for 10 seconds on large histories and then abort.

Closes #44429

@ywelsch ywelsch added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.0.0 v7.3.0 v7.4.0 labels Jul 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor Author

ywelsch commented Jul 17, 2019

@elasticmachine run elasticsearch-ci/2

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) (I didn't check the empirical bounds much but I do remember the failed tests for this one taking a long time so makes sense to me)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, seems reasonable to me too. LGTM

@ywelsch ywelsch merged commit 998bb47 into elastic:master Jul 17, 2019
ywelsch added a commit that referenced this pull request Jul 17, 2019
Large histories can be problematic and have the linearizability checker occasionally run OOM. As it's
very difficult to bound the size of the histories just right, this PR will let it instead run for 10 seconds
on large histories and then abort.

Closes #44429
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Oct 31, 2019
Same as elastic#44444 but for the coordinator tests.
Closes elastic#48752
original-brownbear added a commit that referenced this pull request Nov 4, 2019
Same as #44444 but for the coordinator tests.
Closes #48752
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 4, 2019
original-brownbear added a commit that referenced this pull request Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >test Issues or PRs that are addressing/adding tests v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ConcurrentSeqNoVersioningIT.testSeqNoCASLinearizability fails with out of memory
5 participants