Tests for Range Fields on VST.ANY aggregations #44502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>non-issue
>test
Collaborator
|
Pinging @elastic/es-analytics-geo |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides tests for the behavior of the range fields on aggregations that use ValuesSourceType.ANY. This PR doesn't add support for ranges, merely checks that aggregations which we expect to "just work" with ranges do, and that the behavior of other "Any" type aggregations is consistent.
I didn't add a test for Diversified because (a) it's very clear what the behavior is from the code and (b) it's under-tested as is, so it'd be a lot of code to add in tests for this. I still might, but wanted to get the easy tests up for review first.