-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit processors by available processors #44894
Merged
jasontedor
merged 7 commits into
elastic:master
from
jasontedor:limit-processors-by-available-processors
Jul 26, 2019
Merged
Limit processors by available processors #44894
jasontedor
merged 7 commits into
elastic:master
from
jasontedor:limit-processors-by-available-processors
Jul 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit limits the processors setting to be more than the number of available processors.
jasontedor
added
>breaking
:Core/Infra/Core
Core issues without another label
v8.0.0
labels
Jul 26, 2019
jasontedor
force-pushed
the
limit-processors-by-available-processors
branch
from
July 26, 2019 08:20
3c9fc38
to
931503c
Compare
Pinging @elastic/es-core-infra |
jpountz
approved these changes
Jul 26, 2019
default sizes for the thread pools to be more than the number of available | ||
processors. As this leads to more context switches and more threads but without | ||
an increase in the number of physical CPUs on which to schedule these additional | ||
threads, the `processors` setting is now bounded by the number of available processors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: does the last line need wrapping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I pushed.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 26, 2019
* Due to elastic#44894 some constellations log a deprecation warning here now * Fixed by checking for that
original-brownbear
added a commit
that referenced
this pull request
Jul 26, 2019
* Due to #44894 some constellations log a deprecation warning here now * Fixed by checking for that
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 26, 2019
* Due to elastic#44894 some constellations log a deprecation warning here now * Fixed by checking for that
original-brownbear
added a commit
that referenced
this pull request
Jul 26, 2019
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
* Due to #44894 some constellations log a deprecation warning here now * Fixed by checking for that
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
This commit limits the processors setting to be more than the number of available processors.
fdartayre
added a commit
that referenced
this pull request
Sep 15, 2022
Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors #44894
lockewritesdocs
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Update threadpool.asciidoc Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors #44894 * Update docs/reference/modules/threadpool.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co>
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 27, 2022
* Update threadpool.asciidoc Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors elastic#44894 * Update docs/reference/modules/threadpool.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit fe0036f)
lockewritesdocs
pushed a commit
to lockewritesdocs/elasticsearch
that referenced
this pull request
Oct 27, 2022
* Update threadpool.asciidoc Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors elastic#44894 * Update docs/reference/modules/threadpool.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit fe0036f) # Conflicts: # docs/reference/modules/threadpool.asciidoc
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Update threadpool.asciidoc Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors #44894 * Update docs/reference/modules/threadpool.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit fe0036f) Co-authored-by: Frederic Dartayre <30438455+fdartayre@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 27, 2022
* Update threadpool.asciidoc Starting from 8.0 the value of the `node.processors` setting is bounded by the number of available processors #44894 * Update docs/reference/modules/threadpool.asciidoc Co-authored-by: Adam Locke <adam.locke@elastic.co> (cherry picked from commit fe0036f) # Conflicts: # docs/reference/modules/threadpool.asciidoc Co-authored-by: Frederic Dartayre <30438455+fdartayre@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit limits the processors setting to be more than the number of available processors.
Relates #44889