Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit processors by available processors #44894

Merged

Conversation

jasontedor
Copy link
Member

This commit limits the processors setting to be more than the number of available processors.

Relates #44889

This commit limits the processors setting to be more than the number of
available processors.
@jasontedor jasontedor added >breaking :Core/Infra/Core Core issues without another label v8.0.0 labels Jul 26, 2019
@jasontedor jasontedor requested a review from jpountz July 26, 2019 08:20
@jasontedor jasontedor force-pushed the limit-processors-by-available-processors branch from 3c9fc38 to 931503c Compare July 26, 2019 08:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

default sizes for the thread pools to be more than the number of available
processors. As this leads to more context switches and more threads but without
an increase in the number of physical CPUs on which to schedule these additional
threads, the `processors` setting is now bounded by the number of available processors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: does the last line need wrapping?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I pushed.

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 26, 2019
* Due to elastic#44894 some constellations log a deprecation warning here now
* Fixed by checking for that
original-brownbear added a commit that referenced this pull request Jul 26, 2019
* Due to #44894 some constellations log a deprecation warning here now
* Fixed by checking for that
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jul 26, 2019
* Due to elastic#44894 some constellations log a deprecation warning here now
* Fixed by checking for that
original-brownbear added a commit that referenced this pull request Jul 26, 2019
* Due to #44894 some constellations log a deprecation warning here now
* Fixed by checking for that
@jasontedor jasontedor merged commit 5b2d1a5 into elastic:master Jul 26, 2019
@jasontedor jasontedor deleted the limit-processors-by-available-processors branch July 26, 2019 15:07
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
* Due to #44894 some constellations log a deprecation warning here now
* Fixed by checking for that
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
This commit limits the processors setting to be more than the number of
available processors.
fdartayre added a commit that referenced this pull request Sep 15, 2022
Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors #44894
lockewritesdocs pushed a commit that referenced this pull request Oct 26, 2022
* Update threadpool.asciidoc

Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors #44894

* Update docs/reference/modules/threadpool.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 27, 2022
* Update threadpool.asciidoc

Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors elastic#44894

* Update docs/reference/modules/threadpool.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>
(cherry picked from commit fe0036f)
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Oct 27, 2022
* Update threadpool.asciidoc

Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors elastic#44894

* Update docs/reference/modules/threadpool.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>
(cherry picked from commit fe0036f)

# Conflicts:
#	docs/reference/modules/threadpool.asciidoc
elasticsearchmachine pushed a commit that referenced this pull request Oct 27, 2022
* Update threadpool.asciidoc

Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors #44894

* Update docs/reference/modules/threadpool.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>
(cherry picked from commit fe0036f)

Co-authored-by: Frederic Dartayre <30438455+fdartayre@users.noreply.github.com>
elasticsearchmachine pushed a commit that referenced this pull request Oct 27, 2022
* Update threadpool.asciidoc

Starting from 8.0 the value of the `node.processors` setting is  bounded by the number of available
processors #44894

* Update docs/reference/modules/threadpool.asciidoc

Co-authored-by: Adam Locke <adam.locke@elastic.co>
(cherry picked from commit fe0036f)

# Conflicts:
#	docs/reference/modules/threadpool.asciidoc

Co-authored-by: Frederic Dartayre <30438455+fdartayre@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Core/Infra/Core Core issues without another label v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants