Skip to content

Rename indexlifecycle to ilm and snapshotlifecycle to slm #44917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dakrone merged 2 commits into from
Jul 29, 2019
Merged

Rename indexlifecycle to ilm and snapshotlifecycle to slm #44917

dakrone merged 2 commits into from
Jul 29, 2019

Conversation

@dakrone
Copy link
Member

@dakrone dakrone commented Jul 26, 2019

As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.

@dakrone
Rename indexlifecycle to ilm and snapshotlifecycle to slm
643a30b 
As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
@dakrone dakrone added >non-issue :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.4.0 labels Jul 26, 2019
@dakrone dakrone requested a review from jasontedor July 26, 2019 17:30
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 26, 2019

Pinging @elastic/es-core-features

@dakrone
Copy link
Member Author

dakrone commented Jul 26, 2019 •
edited
Loading

The only thing that this does not rename is the indexlifecycle package within the HLRC, which, because that has already been released, would be a breaking change for users of the HLRC.

Do we want to rename that as well? I would like to since it brings it in to parity with the rest of the code, but it is a breaking change in that case. (the same comment about logging applies here as well)

@dakrone dakrone requested a review from gwbrown July 26, 2019 17:33
gwbrown
gwbrown approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@gwbrown gwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dakrone. I'm inclined to agree that changing this package in 7.x would be a breaking change - especially since this is basically just an aesthetic change. I would be in favor of renaming the HLRC package in master only.

jasontedor
jasontedor approved these changes Jul 27, 2019
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am good with this change. I am okay one way or the other with changing the package name in the HLRC in 7.x (we should of course change the package name in master).

@dakrone dakrone merged commit ea93328 into elastic:master Jul 29, 2019
@dakrone dakrone deleted the rename-slm-and-ilm branch July 29, 2019 17:14
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 29, 2019
@dakrone
Rename indexlifecycle to ilm and snapshotlifecycle to slm (elastic#44917
90cad06 
)

As a followup to elastic#44725 and elastic#44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
@dakrone dakrone mentioned this pull request Jul 29, 2019
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jul 29, 2019
@dakrone
Rename HLRC 'indexlifecycle' components to 'ilm'
c157ada 
Related to elastic#44917 and elastic#44725, this commit renames the HLRC components
for indexlifecycle to ilm.
@dakrone dakrone mentioned this pull request Jul 29, 2019
Merged
dakrone added a commit that referenced this pull request Jul 29, 2019
@dakrone
[7.x] Rename indexlifecycle to ilm and snapshotlifecycle to sl… (#44977)
598c4e7 
* Rename indexlifecycle to ilm and snapshotlifecycle to slm (#44917)

As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.

* Fix one more import
dakrone added a commit that referenced this pull request Jul 30, 2019
@dakrone
Rename HLRC 'indexlifecycle' components to 'ilm' (#44982)
9677d04 
Related to #44917 and #44725, this commit renames the HLRC components
for indexlifecycle to ilm.
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
@dakrone @jkakavas
Rename indexlifecycle to ilm and snapshotlifecycle to slm (#44917)
3f80ff8 
As a followup to #44725 and #44608, which renamed the packages within
the x-pack project, this renames the packages within the core x-pack
project. It also renames 'snapshotlifecycle' within the HLRC to slm.
jkakavas pushed a commit that referenced this pull request Jul 31, 2019
@dakrone @jkakavas
Rename HLRC 'indexlifecycle' components to 'ilm' (#44982)
6acea3c 
Related to #44917 and #44725, this commit renames the HLRC components
for indexlifecycle to ilm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasontedor jasontedor jasontedor approved these changes

+1 more reviewer

@gwbrown gwbrown gwbrown approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >non-issue v7.4.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dakrone @elasticmachine @gwbrown @jasontedor @jakelandis