Isolate Request in Call-Chain for REST Request Handling #45130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
original-brownbear
commented
Aug 2, 2019
original-brownbear
commented
- Follow up to Stop Passing Around REST Request in Multiple Spots #44949
- Stop using a special code path for multi-line JSON and instead handle its detection like that of other XContent types when creating the request
- Only leave a single path that holds a reference to the full REST request
- In the next step we can move the copying of request content to happen before the actual request handling and make it conditional on the handler in question to stop copying bulk requests as suggested in Stop Copying Every Http Request in Message Handler #44564
* Follow up to elastic#44949 * Stop using a special code path for multi-line JSON and instead handle its detection like that of other XContent types when creating the request * Only leave a single path that holds a reference to the full REST request * In the next step we can move the copying of request content to happen before the actual request handling and make it conditional on the handler in question to stop copying bulk requests as suggested in elastic#44564
original-brownbear
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
|
I’ll take a look at this tomorrow. |
Contributor
Author
|
Thanks @tbrooks8 ! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Aug 10, 2019
* Follow up to elastic#44949 * Stop using a special code path for multi-line JSON and instead handle its detection like that of other XContent types when creating the request * Only leave a single path that holds a reference to the full REST request * In the next step we can move the copying of request content to happen before the actual request handling and make it conditional on the handler in question to stop copying bulk requests as suggested in elastic#44564
original-brownbear
added a commit
that referenced
this pull request
Aug 10, 2019
) * Follow up to #44949 * Stop using a special code path for multi-line JSON and instead handle its detection like that of other XContent types when creating the request * Only leave a single path that holds a reference to the full REST request * In the next step we can move the copying of request content to happen before the actual request handling and make it conditional on the handler in question to stop copying bulk requests as suggested in #44564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.