Call afterWriteOperation after trim translog in peer recovery #45182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>test
Collaborator
|
Pinging @elastic/es-distributed |
ywelsch
reviewed
Aug 5, 2019
server/src/test/java/org/elasticsearch/indices/recovery/RecoveryTests.java
Outdated
Show resolved
Hide resolved
dnhatn
changed the title
Member
Author
|
Thanks @ywelsch. |
dnhatn
added a commit
that referenced
this pull request
Aug 11, 2019
testShouldFlushAfterPeerRecovery was added #28350 to make sure the flushing loop triggered by afterWriteOperation eventually terminates. This test relies on the fact that we call afterWriteOperation after making changes in translog. In #44756, we roll a new generation in RecoveryTarget#finalizeRecovery but do not call afterWriteOperation. Relates #28350 Relates #45073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testShouldFlushAfterPeerRecoverywas added #28350 to make sure the flushing loop triggered byafterWriteOperationeventually terminates. This test relies on the fact that we callafterWriteOperationafter making changes in translog. In #44756, we roll a new generation inRecoveryTarget#finalizeRecoverybut do not callafterWriteOperation.Relates #28350
Relates #45073
CI: https://scans.gradle.com/s/434yf54fgevvm