Fix build cache misses caused by embedded reaper jar #45404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <portugee@gmail.com>
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
mark-vieira
added a commit
that referenced
this pull request
Aug 10, 2019
(cherry picked from commit 788fece)
Contributor
|
added |
Contributor
Author
|
Thanks, @pcsanwald! I forgot to put the version labels on this one. This was backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #45347 which didn't actually fix the problem.
Essentially the input normalization technique doesn't work here. Simply including the
reaper.jarin thebuildSrc.jarwill cause the Gradle build classpath to constantly change. The workaround here is to only embed the JAR when building thebuild-tools.jar. When running inside the Elasticsearch build we instead just find the JAR on the classpath rather then copying it from inside the buildSrc jar itself. To ensure this works for external build-tools users we've introduced some test coverage here for that scenario.