Fix policy removal bug in delete policy #45573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The delete policy had a subtle bug in that it would still delete the policy if pipelines were accessing it, after giving the client back an error. This commit fixes that and ensures it does not happen by adding verification in the test.
hub-cap
added
the
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-core-features |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/1 |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Member
|
@elasticmachine run elasticsearch-ci/bwc |
Member
|
I'm merging this PR, the test failures are unrelated to enrich (dataframe bwc failures). |
martijnvg
pushed a commit
that referenced
this pull request
Aug 15, 2019
The delete policy had a subtle bug in that it would still delete the policy if pipelines were accessing it, after giving the client back an error. This commit fixes that and ensures it does not happen by adding verification in the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The delete policy had a subtle bug in that it would still delete the
policy if pipelines were accessing it, after giving the client back an
error. This commit fixes that and ensures it does not happen by adding
verification in the test.