Log deprecation warning if es.transport.cname_in_publish_address prop… #45662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erty is specified
andrershov
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 18, 2024
This propery has been a deprecated no-op since elastic#45662 (8.0.0). This commit removes it entirely in 9.0.0.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 18, 2024
This propery has been a deprecated no-op since #45662 (8.0.0). This commit removes it entirely in 9.0.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #45626.
Now we always output transport.publish_address with CNAME and log deprecation warning if es.transport.cname_in_publish_address property is specified.
This PR also adds a test which will fail once Elasticsearch version is changed to 9, to make sure we remove the property when doing reversioning.
Closes #39970