-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject misconfigured/ambiguous SSL server config #45892
Merged
Merged
Commits on Aug 23, 2019
-
Reject misconfigured/ambiguous SSL server config
This commit makes it an error to start a node where either of the server contexts (xpack.security.transport.ssl and xpack.security.http.ssl) meet either of these conditions: 1. The server lacks a certificate/key pair (i.e. neither ssl.keystore.path not ssl.certificate are configured) 2. The server has some ssl configuration, but ssl.enabled is not specified. This new validation does not care whether ssl.enabled is true or false (though other validation might), it simply makes it an error to configure server SSL without being explicit about whether to enable that configuration.
Configuration menu - View commit details
-
Copy full SHA for 0bf29a6 - Browse repository at this point
Copy the full SHA 0bf29a6View commit details
Commits on Aug 27, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e25a370 - Browse repository at this point
Copy the full SHA e25a370View commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 26b0944 - Browse repository at this point
Copy the full SHA 26b0944View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9b73a6 - Browse repository at this point
Copy the full SHA d9b73a6View commit details -
We added a few tests with invalid config while this PR was stagnant
Configuration menu - View commit details
-
Copy full SHA for 535094f - Browse repository at this point
Copy the full SHA 535094fView commit details
Commits on Oct 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for a681ed7 - Browse repository at this point
Copy the full SHA a681ed7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7077b90 - Browse repository at this point
Copy the full SHA 7077b90View commit details -
Configuration menu - View commit details
-
Copy full SHA for fced860 - Browse repository at this point
Copy the full SHA fced860View commit details
Commits on Nov 5, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 8666968 - Browse repository at this point
Copy the full SHA 8666968View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b74feb - Browse repository at this point
Copy the full SHA 5b74febView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd7a95e - Browse repository at this point
Copy the full SHA fd7a95eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1791f16 - Browse repository at this point
Copy the full SHA 1791f16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.