Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject misconfigured/ambiguous SSL server config #45892

Merged
merged 12 commits into from
Nov 7, 2019

Commits on Aug 23, 2019

  1. Reject misconfigured/ambiguous SSL server config

    This commit makes it an error to start a node where either of the
    server contexts (xpack.security.transport.ssl and
    xpack.security.http.ssl) meet either of these conditions:
    
    1. The server lacks a certificate/key pair (i.e. neither
       ssl.keystore.path not ssl.certificate are configured)
    2. The server has some ssl configuration, but ssl.enabled is not
       specified. This new validation does not care whether ssl.enabled is
       true or false (though other validation might), it simply makes it
       an error to configure server SSL without being explicit about
       whether to enable that configuration.
    tvernum committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    0bf29a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2019

  1. Configuration menu
    Copy the full SHA
    e25a370 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Configuration menu
    Copy the full SHA
    26b0944 View commit details
    Browse the repository at this point in the history
  2. Address feedback

    tvernum committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    d9b73a6 View commit details
    Browse the repository at this point in the history
  3. Fix broken tests

    We added a few tests with invalid config while this PR was stagnant
    tvernum committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    535094f View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Configuration menu
    Copy the full SHA
    a681ed7 View commit details
    Browse the repository at this point in the history
  2. Update error message

    tvernum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    7077b90 View commit details
    Browse the repository at this point in the history
  3. Fix HLRC tests

    tvernum committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    fced860 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Configuration menu
    Copy the full SHA
    8666968 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b74feb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd7a95e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1791f16 View commit details
    Browse the repository at this point in the history