-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for API specification #46522
Fixes for API specification #46522
Conversation
Pinging @elastic/es-distributed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment, this ends up adding an invalid endpoint
} | ||
}, | ||
{ | ||
"path":"/_slm/policy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SLM delete policy does not support a path without the {policy_id}
parameter, it's not allowed at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dakrone! I was under the impression that a path without the policy_id
was allowed, because in the original implementation, before the new spec format, the policy_id
was not marked as required
: https://github.com/elastic/elasticsearch/blob/a2e0db7783055300de77f3a0e525a21ac2bd7530/x-pack/plugin/src/test/resources/rest-api-spec/api/slm.delete_lifecycle.json
I'll update the spec.
Pinging @elastic/es-core-features |
Pinging @elastic/es-core-infra |
Had a look at - "description": "Parameters that are accepted by all API endpoints.",
- "documentation": "https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html",
+ "documentation": {
+ "url": "https://www.elastic.co/guide/en/elasticsearch/reference/current/common-options.html",
+ "description": "Parameters that are accepted by all API endpoints."
+ }, It looks like the parsing for Gonna tag |
After #42346, some documentation link the and definition of
slm.delete_lifecycle
were not correct, this pr fixes them.Related: #44487 #45102
This should also be backported to
7.x
.cc @elastic/es-clients