[HLRC] Send min_score as query string parameter to the count API #46829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to elastic#46474
Collaborator
|
Pinging @elastic/es-core-features |
jimczi
approved these changes
Sep 20, 2019
Contributor
jimczi
left a comment
jimczi
left a comment
There was a problem hiding this comment.
LGTM, I also wonder if we should replace the SearchSourceBuilder with a simple QueryBuilder in order to ensure that we don't send invalid content ?
Member
Author
I was thinking the same. I will do that in a followup PR. |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
martijnvg
added a commit
that referenced
this pull request
Sep 20, 2019
) Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to #46474
martijnvg
added a commit
that referenced
this pull request
Sep 20, 2019
) Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to #46474
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Sep 20, 2019
Currently the CountRequest accepts a search source builder, while the RestCountAction only accepts a top level query object. This can lead to confusion if another element (e.g. aggregations) is specified, because that will be ignored on the server side in RestCountAction. By deprecating the current setter & constructor that accept a SearchSourceBuilder and adding replacement that accepts a QueryBuilder it is clear what the count api can handle from HLRC side. Follow up from elastic#46829
martijnvg
added a commit
that referenced
this pull request
Sep 23, 2019
Currently the CountRequest accepts a search source builder, while the RestCountAction only accepts a top level query object. This can lead to confusion if another element (e.g. aggregations) is specified, because that will be ignored on the server side in RestCountAction. By deprecating the current setter & constructor that accept a SearchSourceBuilder and adding replacement that accepts a QueryBuilder it is clear what the count api can handle from HLRC side. Follow up from #46829
martijnvg
added a commit
that referenced
this pull request
Sep 23, 2019
Currently the CountRequest accepts a search source builder, while the RestCountAction only accepts a top level query object. This can lead to confusion if another element (e.g. aggregations) is specified, because that will be ignored on the server side in RestCountAction. By deprecating the current setter & constructor that accept a SearchSourceBuilder and adding replacement that accepts a QueryBuilder it is clear what the count api can handle from HLRC side. Follow up from #46829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit min_score was sent as request body parameter
(via SearchSourceBuilder), which is not possible in the count api.
Similar to #46474