SQL: Add examples fo muting sql/csv integ tests #47291
Conversation
Add examples of failures for both sql and csv tests and instructions on how to mute them.
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci/2 |
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM, but the instructions about which file to check is the same for both sql-spec and csv-spec files. Since you have two examples files - sql and csv - I am assuming you'd want to reference each of them in the corresponding file type.
|
@astefan, Thx, made some global replace at some point and messed it up. |
costin
left a comment
costin
left a comment
There was a problem hiding this comment.
Left a few minor comments - LGTM otherwise.
| // java.lang.AssertionError: Elasticsearch [JdbcResultSet:row 4:cursor size 2:[languages<type=[BYTE]>, 'F'<type=[DOUBLE]>]] still has data after [3] entries: | ||
| // 3 | 53660.0 | ||
| // at __randomizedtesting.SeedInfo.seed([81AF0740AC9F7D95:9FB389A0263106D]:0) | ||
| // at org.elasticsearch.xpack.sql.qa.single_node.JdbcCsvSpecIT.pivot.testAverageWithOneValueAndLimit(pivot.csv-spec:95) |
There was a problem hiding this comment.
It's worth pointing out that the stacktrace contains the file and line of the test that fails, just in case the assignee hasn't noticed that already.
|
|
||
|
|
||
| // Test failure example: | ||
| // org.elasticsearch.xpack.sql.qa.single_node.JdbcSqlSpecIT > test {agg.testGroupByOnText} FAILED |
There was a problem hiding this comment.
This stacktrace is not useful, one with the .sql resource in it is more common (similar to the csv one).
Add examples of failures for both sql and csv integeration tests and instructions on how to mute them. (cherry picked from commit 591bba4)
5 participants
Add examples of failures for both sql and csv tests and
instructions on how to mute them.