Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apm system monitoring 7x #47302

Closed
wants to merge 2 commits into from

Conversation

cachedout
Copy link
Contributor

@cachedout cachedout commented Sep 30, 2019

This is a fix for the issue described here: elastic/apm-server#2708

This extends changes made here to the apm_system user: #40876

This is specifically made against the 7.x branch because in 8.0, we want to remove internal collectors for monitored services and so the configuration in the original bug report would not be supported. That said, I don't know if this is the preference of the Elasticsearch team and I defer to whatever they would like to do in that regard.

@cachedout
Copy link
Contributor Author

@axw Can you confirm that this fixes the issue that you described in elastic/apm-server#2708

@jakelandis Could you please help me find the appropriate reviewers for this change on the Elasticsearch team?

@cachedout cachedout marked this pull request as ready for review October 7, 2019 08:00
@jakelandis
Copy link
Contributor

This is specifically made against the 7.x branch because in 8.0, we want to remove internal collectors for monitored services and so the configuration in the original bug report would not be supported. That said, I don't know if this is the preference of the Elasticsearch team and I defer to whatever they would like to do in that regard.

@cachedout
Could you please introduce this to 8.0 and then backport to 7.x. Unless the conflicting change is already in master, it is preferred to add it and then remove it at the appropriate time.

@cachedout
Copy link
Contributor Author

@jakelandis Will do. Thanks!

@cachedout cachedout closed this Oct 7, 2019
@axw
Copy link
Member

axw commented Oct 7, 2019

@cachedout I've tested APM Server 7.2 with your ES branch, and it's working. Thanks!

@cachedout cachedout mentioned this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants